[Mono.Posix] Add @(ProjectReference) for Xamarin.Android.Build.Tasks #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[@atsushieno is unable to build from a clean state on Linux][0], because when `src/Mono.Posix` is built `class-parse.exe` can't be found: error XA0020: Could not find mandroid! (Yes, the error says `mandroid`, but it's the `$prefix/lib/mandroid` directory it's complaining about, which contains `class-parse.exe`.) This doesn't immediately make sense, because `Xamarin.Android.Build.Tasks.csproj` has a `@(ProjectReference)` on the `class-parse.csproj` project, and thus `class-parse.exe` *should* exist...unless `Xamarin.Andorid.Build.Tasks.csproj` hasn't been built! Indeed, `Mono.Posix.csproj` does *not* contain a `@(ProjectReference)` on `Xamarin.Android.Build.Tasks.csproj`, and thus there is no requirement known by MSBuild that `Xamarin.Android.Build.Tasks` be built before `Mono.Posix`. This could explain why `class-parse.exe` can't be found. (Though this itself seems a tad odd, because if `Xamarin.Android.Build.Tasks.csproj` wasn't built at all, then I'd expect the `<Import/>` within `Mono.Posix.csproj` for `$(OutputPath)\..\..\..\xbuild\Xamarin\Android\Xamarin.Android.CSharp.targets` to fail *first*, but that's not the reported error...) Fix the `Mono.Posix.csproj` and `Mono.Data.Sqlite.csproj` projects so that they depend upon `Xamarin.Android.Build.Tasks.csproj`, to ensure that build dependencies are roperly expressed. [0]: https://gitter.im/xamarin/xamarin-android?at=575e94fa064b9e7266f204c3
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Mono 4.8 has migrated to Mono.Cecil/master, based on 0.10.0, which is API-incompatible with the previous Mono.Cecil 0.9.6. In particular, `TypeDefinition.Interfaces` now returns a `Collection<InterfaceImplementation>` instead of the previous `Collection<TypeReference>`, which causes all manner of breakage. Since the next version of Xamarin.Android will be based on Mono 4.8, and Xamarin.Android needs Java.Interop, bump Java.Interop to use the Mono.Cecil 0.10.x preview package, and fix the corresponding breakage.
jonpryor
pushed a commit
that referenced
this pull request
Feb 18, 2021
Changes: dotnet/android-libzipsharp@1.0.20...1.0.22 * dotnet/android-libzipsharp@9f563dd: Add a test which changes the CompressionMethod of an item (#78) * dotnet/android-libzipsharp@3b610c9: Try actually running the tests under .net core (#77) * dotnet/android-libzipsharp@03cd66b: Archive the SignList.xml * dotnet/android-libzipsharp@8afe791: Add the signListPath parameter * dotnet/android-libzipsharp@ed5585c: Add SignList.xml for signing * dotnet/android-libzipsharp@2ab6943: Add a build_windows.bat file to make it easier to build on windows (#75) * … * dotnet/android-libzipsharp@9dca4fb: Initial commit of localisation * dotnet/android-libzipsharp@668babc: Add Unit Test for setting file permissions on extraction. * dotnet/android-libzipsharp@8f2053c: Build on Windows again (#71)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atsushieno is unable to build from a clean state on Linux,
because when
src/Mono.Posixis builtclass-parse.execan't befound:
(Yes, the error says
mandroid, but it's the$prefix/lib/mandroiddirectory it's complaining about, which contains
class-parse.exe.)This doesn't immediately make sense, because
Xamarin.Android.Build.Tasks.csprojhas a@(ProjectReference)onthe
class-parse.csprojproject, and thusclass-parse.exeshouldexist...unless
Xamarin.Andorid.Build.Tasks.csprojhasn't been built!Indeed,
Mono.Posix.csprojdoes not contain a@(ProjectReference)on
Xamarin.Android.Build.Tasks.csproj, and thus there is norequirement known by MSBuild that
Xamarin.Android.Build.Tasksbebuilt before
Mono.Posix. This could explain whyclass-parse.execan't be found.
(Though this itself seems a tad odd, because if
Xamarin.Android.Build.Tasks.csprojwasn't built at all, then I'dexpect the
<Import/>withinMono.Posix.csprojfor$(OutputPath)\..\..\..\xbuild\Xamarin\Android\Xamarin.Android.CSharp.targetsto fail first, but that's not the reported error...)
Fix the
Mono.Posix.csprojandMono.Data.Sqlite.csprojprojects sothat they depend upon
Xamarin.Android.Build.Tasks.csproj, to ensurethat build dependencies are roperly expressed.