get Mono.Data.Sqlite build without problem. #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <SignAssembly>True</SignAssembly> | ||
| <AndroidUseSharedRuntime>False</AndroidUseSharedRuntime> | ||
| <SignAssembly>true</SignAssembly> | ||
| <AssemblyOriginatorKeyFile>..\..\product.snk</AssemblyOriginatorKeyFile> |
Contributor
There was a problem hiding this comment.
This is a different signing key than what Mono.Data.Sqlite.dll is currently built with, so I believe this would break existing 3rd party assemblies.
- It did not build because xbuild tries to build it with "the latest runtime" which is (to it) 6.0.99 while we don't really build it here. - Reference paths are now indicated by hintpaths. Other couple of build properties are revised to match Mono.Posix build (e.g. signing key file).
atsushieno
force-pushed
the
fix-sqlite-csproj-build
branch
from
942585c to
51007b9
Compare
| <MonoAndroidResourcePrefix>Resources</MonoAndroidResourcePrefix> | ||
| <AndroidResgenClass>Resource</AndroidResgenClass> | ||
| <AndroidResgenFile>Resources\Resource.designer.cs</AndroidResgenFile> | ||
| <AndroidUseLatestPlatformSdk>True</AndroidUseLatestPlatformSdk> |
Contributor
There was a problem hiding this comment.
What IDE version are you using that it's making these changes? XS 6.0 seems to be using True instead of true now, so I'm hesitant/curious about these <PropertyGroup/> changes.
The @(Reference) changes should be fine.
Contributor
Author
There was a problem hiding this comment.
I'm NOT using IDEs. Everything is done in text editor. It is actually following the values from Mono.Posix.csproj.
radical
pushed a commit
that referenced
this pull request
May 8, 2018
#75) We have been blindly generating XPath metadata, but some of those are not generated via Java code, and for such code there is no corresponding applicable XML elements that can apply XPath metadata fixup. So, remove them from the output.
jonpryor
pushed a commit
that referenced
this pull request
Feb 18, 2021
Changes: dotnet/android-libzipsharp@1.0.20...1.0.22 * dotnet/android-libzipsharp@9f563dd: Add a test which changes the CompressionMethod of an item (#78) * dotnet/android-libzipsharp@3b610c9: Try actually running the tests under .net core (#77) * dotnet/android-libzipsharp@03cd66b: Archive the SignList.xml * dotnet/android-libzipsharp@8afe791: Add the signListPath parameter * dotnet/android-libzipsharp@ed5585c: Add SignList.xml for signing * dotnet/android-libzipsharp@2ab6943: Add a build_windows.bat file to make it easier to build on windows (#75) * … * dotnet/android-libzipsharp@9dca4fb: Initial commit of localisation * dotnet/android-libzipsharp@668babc: Add Unit Test for setting file permissions on extraction. * dotnet/android-libzipsharp@8f2053c: Build on Windows again (#71)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime" which is (to it) 6.0.99 while we don't really build it here.
Other couple of build properties are revised to match Mono.Posix build
(e.g. signing key file).