[Xamarin.Android.Build.Tasks] [Cycle 7, VS 2013 only] "'System.ComponentModel.INotifyPropertyChanged' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.ObjectModel" for Android projects that reference PCLs that use INotifyPropertyChange
#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entModel.INotifyPropertyChanged' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.ObjectModel" for Android projects that reference PCLs that use `INotifyPropertyChange Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=41665 Xamarin.Android makes use of Java.Interop which relies on System.Runtime.dll. However it seems that while VS2015 is great at auto picking up that fact VS2013 is not. The task RefolveAssemblyReference (according to the docs) does NOT set $(DependsOnSystemRuntime) when in the VS2013 tool chain. As a result none of our custom PCL Facades tasks were running. Adding the reference to System.ObjectModel.dll just hides the problem. If a different assembly was required you'd end up with and error for that too. The fix is to manually set $(DependsOnSystemRuntime) in our build targets. Since we rely on System.Runtime now anyway it should be have any impact other than to keep VS2013 happy.
radical
pushed a commit
that referenced
this pull request
May 8, 2018
It is to be used by msbuild tasks that splits API XML adjuster work from BindingsGenerator and thus reduce the need to run class-parse and/or API XML adjuster work in generator and thus reduce the chance to load class-parse XML which is almost twice as big as api-xml-adjuster outputs.
jonpryor
pushed a commit
that referenced
this pull request
Feb 18, 2021
Changes: dotnet/android-libzipsharp@1.0.20...1.0.22 * dotnet/android-libzipsharp@9f563dd: Add a test which changes the CompressionMethod of an item (#78) * dotnet/android-libzipsharp@3b610c9: Try actually running the tests under .net core (#77) * dotnet/android-libzipsharp@03cd66b: Archive the SignList.xml * dotnet/android-libzipsharp@8afe791: Add the signListPath parameter * dotnet/android-libzipsharp@ed5585c: Add SignList.xml for signing * dotnet/android-libzipsharp@2ab6943: Add a build_windows.bat file to make it easier to build on windows (#75) * … * dotnet/android-libzipsharp@9dca4fb: Initial commit of localisation * dotnet/android-libzipsharp@668babc: Add Unit Test for setting file permissions on extraction. * dotnet/android-libzipsharp@8f2053c: Build on Windows again (#71)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=41665
Xamarin.Android makes use of Java.Interop which relies on System.Runtime.dll.
However it seems that while VS2015 is great at auto picking up that
fact VS2013 is not. The task RefolveAssemblyReference (according to the docs)
does NOT set $(DependsOnSystemRuntime) when in the VS2013 tool chain.
As a result none of our custom PCL Facades tasks were running.
Adding the reference to System.ObjectModel.dll just hides the problem.
If a different assembly was required you'd end up with and error for that too.
The fix is to manually set $(DependsOnSystemRuntime) in our build targets.
Since we rely on System.Runtime now anyway it should be have any impact other
than to keep VS2013 happy.