manual update mu 20211216 `androidx.window:*-1.0.0`(stable) #449

moljac · 2021-12-16T14:01:15Z

Does this change any of the generated binding API's?

no API changes for androidx.window:*-1.0.0

new version of kotlin-stdlib

Describe your contribution

update of androidx.window:*-1.0.0
necessary dependencies updates and metadata fixes

Updated

androidx.window:window - 1.0.0-beta04 -> 1.0.0
androidx.window:window-java - 1.0.0-beta04 -> 1.0.0
org.jetbrains.kotlin:kotlin-stdlib - 1.5.31 -> 1.6.0
org.jetbrains.kotlin:kotlin-stdlib-common - 1.5.31 -> 1.6.0
org.jetbrains.kotlin:kotlin-stdlib-jdk7 - 1.5.31 -> 1.6.0
org.jetbrains.kotlin:kotlin-stdlib-jdk8 - 1.5.31 -> 1.6.0

test NuGets from CI dotnet/android-libraries#449

conceptdev · 2021-12-17T00:26:51Z

I pulled the NuGet packages from the CI and added them to a Xamarin.Android test project - seems to work 😊

microsoft/surface-duo-sdk-xamarin-samples#33

Will these NuGets get published? We had a PR for 1.0.0.5-beta04 but I don't see it on https://www.nuget.org/packages/Xamarin.AndroidX.Window.WindowJava/

conceptdev · 2022-01-20T22:50:33Z

@moljac what's the status of this PR? did the stdlib update cause issues?

jpobst · 2022-01-27T20:32:23Z

I think we're going to have to hold off on this until we investigate the breaking changes to Kotlin 1.6 and determine if they're on our side or Kotlin's side:
#436 (comment)

conceptdev · 2022-01-27T22:51:01Z

Thanks @jpobst - let me know how it goes?

I've created another branch and PR #470 so I can (try to) test the latest, stable, release of the package. Obviously, we can't move forward until the Kotlin 1.6 issue is resolved though.

moljac · 2022-01-31T20:05:40Z

Thanks @jpobst - let me know how it goes?

I've created another branch and PR #470 so I can (try to) test the latest, stable, release of the package. Obviously, we can't move forward until the Kotlin 1.6 issue is resolved though.

I downgraded Kotlin StdLib, skipped rc01, so stable is here

Building, cleaning up and preparing for release. Other stable bindings are in:

#468

and that one will be nasty.

…b.com/xamarin/AndroidX into mu-20211216-androidx-window-1.0.0-rc1

moljac · 2022-02-02T15:13:03Z

Thanks @jpobst - let me know how it goes?

I've created another branch and PR #470 so I can (try to) test the latest, stable, release of the package. Obviously, we can't move forward until the Kotlin 1.6 issue is resolved though.

I think I got it with:

  <attr path="/api/package/class/method/parameter[@name='arg0']" name="name">$this</attr>

There are still removed APIs (some obsoleted), but api-diff looks better

moljac · 2022-02-02T15:15:31Z

The Kotlin 1.6 issue is being tracked here: dotnet/java-interop#945.

jpobst · 2022-02-03T00:27:11Z

I don't think changing the parameter name is going to fix it:

Type Changed: Kotlin.UIntArray

Removed methods:

public static uint Get (int[] _this, int index);
public static void Set (int[] _this, int index, uint value);

Added methods:

public static int Get (int[] _this, int index);
public static void Set (int[] _this, int index, int value);

I think the only way to fix this without binding tooling changes would be to change the type of every changed uint/ushort/ulong/ubyte back to the unsigned versions.

…ortArray)

moljac · 2022-02-07T13:15:32Z

I think the only way to fix this without binding tooling changes would be to change the type of every changed uint/ushort/ulong/ubyte back to the unsigned versions.

I changed types back to unsigned versions.

Let us see if that helps, so this is unblocked.

jpobst

Nice! I was afraid fixing this was going to require a lot more metadata than this.

I think we need to switch to type and then we're good to go.

jpobst · 2022-02-07T21:53:25Z

source/Xamarin.Kotlin.StdLib/Transforms/Metadata.xml

+  </attr>
+  <attr
+    path="/api/package[@name='kotlin']/class[@name='UIntArray']/method[@name='set-VXSXFK8' and count(parameter)=3 and parameter[1][@type='int[]'] and parameter[2][@type='int'] and parameter[3][@type='int']]/parameter[3]"
+    name="managedType"


I realize you should always use managedType and are never supposed to use type, but I think in these cases we actually do want type. There is some custom marshalling code that gets generated for Kotlin unsigned types, and I suspect it won't get triggered with managedType. Thus the code may not work correctly at runtime.

I realize you should always use managedType and are never supposed to use type, but I think in these cases we actually do want type. There is some custom marshalling code that gets generated for Kotlin unsigned types, and I suspect it won't get triggered with managedType. Thus the code may not work correctly at runtime.

You know I try not to remove-node and to not change native type and return.

OK. Trying only type (only for parameter)!!

jpobst

👍 LGTM!

* [WindowManager] update to rc01 test NuGets from CI dotnet/android-libraries#449 * [all] update Jetpack Window Manager (rc01) * [all] update Jetpack Window Manager (1.0.0 stable) * tweaks * add comments re 1.0.0.7 stable version update * [windowmanager] config tweaks * update README for Jetpack Window Manager support

moljac added 3 commits December 16, 2021 14:57

updates for androidx.window

4693024

metadata fixes for 1.6.0

c01971e

Update androidx-assemblies.csv

ef047c6

moljac linked an issue Dec 16, 2021 that may be closed by this pull request

Update "AndroidX.Window" to "1.0.0-rc01" #446

Closed

moljac marked this pull request as draft December 16, 2021 14:01

moljac mentioned this pull request Dec 16, 2021

Update AndroidX.Window and WindowJava to rc01 #447

Closed

conceptdev mentioned this pull request Dec 16, 2021

Update "AndroidX.Window" to "1.0.0-rc01" #446

Closed

conceptdev added a commit to microsoft/surface-duo-sdk-xamarin-samples that referenced this pull request Dec 17, 2021

[WindowManager] update to rc01

4216e16

test NuGets from CI dotnet/android-libraries#449

conceptdev mentioned this pull request Dec 17, 2021

[WindowManager] update to rc01 microsoft/surface-duo-sdk-xamarin-samples#33

Closed

moljac added 2 commits December 17, 2021 15:57

Update dependencies.json

6f0e8d5

azure-pipelines.yml version bumps

8daa486

moljac added 3 commits January 24, 2022 17:46

Merge branch 'main' into mu-20211216-androidx-window-1.0.0-rc1

38e9be4

mappings updates

36da18c

Update dependencies.json

a3b1435

moljac marked this pull request as ready for review January 26, 2022 14:44

Update dependencies.json

291296e

moljac requested a review from jpobst January 27, 2022 12:22

conceptdev mentioned this pull request Jan 27, 2022

Update "AndroidX.Window" to "1.0.0" stable release #470

Closed

Merge branch 'main' into mu-20211216-androidx-window-1.0.0-rc1

f2e9d44

moljac added 2 commits January 31, 2022 21:06

stable versions bumps

ffcdc63

Merge branch 'mu-20211216-androidx-window-1.0.0-rc1' of https://githu…

036da7a

…b.com/xamarin/AndroidX into mu-20211216-androidx-window-1.0.0-rc1

moljac changed the title ~~manual update mu 20211216 androidx.window:*-1.0.0-rc1~~ manual update mu 20211216 androidx.window:*-1.0.0(stable) Feb 1, 2022

Merge branch 'main' into mu-20211216-androidx-window-1.0.0-rc1

6d37ade

moljac mentioned this pull request Feb 1, 2022

Update AndroidX.Window and WindowJava to 1.0.0 stable #471

Closed

Update androidx-assemblies.csv

57d7133

moljac added 2 commits February 2, 2022 16:09

Update config.json

8ee2a2f

fixing removed APIs

f21583a

changed types for broken APIs (UByteArray, UIntArray, ULongArray, USh…

ce3739c

…ortArray)

fixed correct type in UByteArray

bf8435f

jpobst reviewed Feb 7, 2022

View reviewed changes

native Kotlin types fixed (not managed)

dee23e7

jpobst approved these changes Feb 8, 2022

View reviewed changes

moljac merged commit 92d48b9 into main Feb 8, 2022

moljac deleted the mu-20211216-androidx-window-1.0.0-rc1 branch February 8, 2022 21:42

manual update mu 20211216 androidx.window:*-1.0.0(stable) #449

manual update mu 20211216 androidx.window:*-1.0.0(stable) #449

Uh oh!

Conversation

moljac commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Does this change any of the generated binding API's?

Describe your contribution

Updated

Uh oh!

conceptdev commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conceptdev commented Jan 20, 2022

Uh oh!

jpobst commented Jan 27, 2022

Uh oh!

conceptdev commented Jan 27, 2022

Uh oh!

moljac commented Jan 31, 2022

Uh oh!

moljac commented Feb 2, 2022

Uh oh!

moljac commented Feb 2, 2022

Uh oh!

jpobst commented Feb 3, 2022

Type Changed: Kotlin.UIntArray

Uh oh!

moljac commented Feb 7, 2022

Uh oh!

jpobst left a comment

Choose a reason for hiding this comment

Uh oh!

jpobst Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

moljac Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpobst left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

manual update mu 20211216 `androidx.window:*-1.0.0`(stable) #449

manual update mu 20211216 `androidx.window:*-1.0.0`(stable) #449

moljac commented Dec 16, 2021 •

edited

Loading

conceptdev commented Dec 17, 2021 •

edited

Loading

moljac Feb 8, 2022 •

edited

Loading