Update AndroidX.Window and WindowJava to 1.0.0 stable #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to require Kotlin 1.6 - TBC if this is causing issues.
Contributor
|
already bumped here With smaller update I am trying with kotlin 1.6.0 if there is too many api-diffs will try to downgrade and then release. If this is OK with you close this PR yourself, please. |
Contributor
Author
|
Closing in favor of #449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #470
Support Libraries Version (eg: 23.3.0):
Does this change any of the generated binding API's?
Does not change any of the APIs that are used by Xamarin clients. Seems to depend on Kotlin 1.6 though.
Describe your contribution
Update "AndroidX.Window" to "1.0.0" for Surface Duo and other foldable devices
Tests
NuGets from the CI on this PR have been tested with the samples at microsoft/surface-duo-sdk-xamarin-samples#34