Weekly Stable Updates 20211202 #436

moljac · 2021-12-03T20:36:35Z

Updated aritfact bindings

androidx.annotation:annotation - 1.2.0 -> 1.3.0
- Xamarin.AndroidX.Annotation
  - diff.md
androidx.collection:collection - 1.1.0 -> 1.2.0
- Xamarin.AndroidX.Collection
  - diff.md
androidx.collection:collection-ktx - 1.1.0 -> 1.2.0
- Xamarin.AndroidX.Collection.Ktx
  - diff.md
  - breaking.md
androidx.compose.animation:animation - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.animation:animation-core - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.foundation:foundation - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.foundation:foundation-layout - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.material:material - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.material:material-icons-core - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.material:material-icons-extended - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.material:material-ripple - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.runtime:runtime - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.runtime:runtime-livedata - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.runtime:runtime-rxjava2 - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.runtime:runtime-saveable - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.ui:ui - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.ui:ui-geometry - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.ui:ui-graphics - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.ui:ui-text - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.ui:ui-unit - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.ui:ui-util - 1.0.0 -> 1.0.5
- no API changes
androidx.compose.ui:ui-viewbinding - 1.0.0 -> 1.0.5
- no API changes
androidx.constraintlayout:constraintlayout - 2.1.1 -> 2.1.2
- Xamarin.AndroidX.ConstraintLayout
  - diff.md
  - breaking.md
androidx.constraintlayout:constraintlayout-core - 1.0.1 -> 1.0.2
- no API changes
androidx.emoji2:emoji2 - -> 1.0.0
- no API changes
androidx.emoji2.emoji2
- Xamarin.AndroidX.Emoji2
  - diff.md
  - breaking.md
androidx.emoji2:emoji2-views-helper - -> 1.0.0
- Xamarin.AndroidX.Emoji2.ViewsHelper
  - diff.md
  - breaking.md
androidx.resourceinspection:resource-inspection-annotation - -> 1.0.0
- no API changes
androidx.lifecycle:lifecycle-common - 2.3.1 -> 2.4.0
- Xamarin.AndroidX.Lifecycle.Common
  - diff.md
androidx.lifecycle:lifecycle-common-java8 - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-livedata - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-livedata-core - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-livedata-core-ktx - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-livedata-ktx - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-process - 2.3.1 -> 2.4.0
- Xamarin.AndroidX.Lifecycle.Process
  - diff.md
  - breaking.md
androidx.lifecycle:lifecycle-reactivestreams - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-reactivestreams-ktx - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-runtime - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-runtime-ktx - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle.lifecycle-runtime-ktx
- Xamarin.AndroidX.Lifecycle.Runtime.Ktx
  - diff.md
androidx.lifecycle:lifecycle-service - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-viewmodel - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle.lifecycle-viewmodel
- Xamarin.AndroidX.Lifecycle.ViewModel
  - diff.md
  - breaking.md
androidx.lifecycle:lifecycle-viewmodel-ktx - 2.3.1 -> 2.4.0
- Xamarin.AndroidX.Lifecycle.ViewModel.Ktx
  - diff.md
  - breaking.md
androidx.lifecycle:lifecycle-viewmodel-savedstate - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle.lifecycle-viewmodel-savedstate
- Xamarin.AndroidX.Lifecycle.ViewModelSavedState
  - diff.md
androidx.paging:paging-common - 3.0.1 -> 3.1.0
- Xamarin.AndroidX.Paging.Common
  - diff.md
  - breaking.md
androidx.paging:paging-common-ktx - 3.0.1 -> 3.1.0
- no API changes
androidx.paging:paging-runtime - 3.0.1 -> 3.1.0
- no API changes
androidx.paging.paging-runtime
- Xamarin.AndroidX.Paging.Runtime
  - diff.md
androidx.paging:paging-runtime-ktx - 3.0.1 -> 3.1.0
- no API changes
androidx.paging:paging-rxjava2 - 3.0.1 -> 3.1.0
- no API changes
androidx.paging:paging-rxjava2-ktx - 3.0.1 -> 3.1.0
- no API changes
androidx.profileinstaller:profileinstaller - 1.0.0 -> 1.0.4
- no API changes
androidx.profileinstaller.profileinstaller
- Xamarin.AndroidX.ProfileInstaller.ProfileInstaller
  - diff.md
  - breaking.md
androidx.work:work-runtime - 2.7.0 -> 2.7.1
- Xamarin.AndroidX.Work.Runtime
  - diff.md
androidx.work:work-runtime-ktx - 2.7.0 -> 2.7.1
- no API changes
io.reactivex.rxjava3:rxjava - 3.1.2 -> 3.1.3
- no API changes
org.jetbrains:annotations - 22.0.0 -> 23.0.0
- Xamarin.Jetbrains.Annotations
  - diff.md

Changed but not updated

androidx.appcompat.appcompat
- Xamarin.AndroidX.AppCompat
  - diff.md
  - breaking.md
androidx.biometric.biometric
- Xamarin.AndroidX.Biometric
  - diff.md
androidx.core.core
- Xamarin.AndroidX.Core
  - diff.md
androidx.leanback.leanback
- Xamarin.AndroidX.Leanback
  - diff.md
  - breaking.md
androidx.recyclerview.recyclerview
- Xamarin.AndroidX.RecyclerView
  - diff.md
androidx.resourceinspection.resourceinspection-annotation
- Xamarin.AndroidX.ResourceInspection.Annotation
  - diff.md
  - breaking.md
androidx.security.security-crypto
- Xamarin.AndroidX.Security.SecurityCrypto
  - diff.md
  - breaking.md
androidx.webkit.webkit
- Xamarin.AndroidX.WebKit
  - diff.md
androidx.window.window
- Xamarin.AndroidX.Window
  - diff.md
  - breaking.md
androidx.window.window-java
- Xamarin.AndroidX.Window.WindowJava
  - diff.md
  - breaking.md
com.google.android.material.material
- Xamarin.Google.Android.Material
  - diff.md
  - breaking.md
com.google.code.gson.gson
- GoogleGson
  - diff.md
com.google.crypto.tink.tink-android
- Xamarin.Google.Crypto.Tink.Android
  - diff.md
  - breaking.md
io.reactivex.rxjava2.rxjava
- Xamarin.Android.ReactiveX.RxJava
  - diff.md
  - breaking.md
org.jetbrains.kotlin.kotlin-stdlib
- Xamarin.Kotlin.StdLib
  - diff.md
  - breaking.md
org.reactivestreams.reactive-streams
- Xamarin.Android.ReactiveStreams
  - diff.md

…to wsu-20211202

PawKanarek · 2022-01-19T11:01:19Z

Hello @moljac i see that some checks have failed due to

@azure-pipelinesazure-pipelines
/ AndroidX (Build macos)
Build log #L14
Error: Certificate "Apple Development: Matthew Leibowitz (Q3RH4N7S8Y)" (fingerprint: AF4469EF01A461E3994C42E2FBF6C0159AF6FB67) expired on Sun Dec 26 2021 00:22:38 GMT+0000 (Coordinated Universal Time)

Do you have idea when this PR will be merged?
I'm asking because I have to bind newest native exoPlayer 2.16.1 library into Xamarin library and it requires dependency androidx.annotation:annotation 1.3.0 which should created in this PR. Without xamarin.annotation 1.3.0 i cannot move any further.

moljac · 2022-01-19T15:42:55Z

@PawKanarek

After this one

#453

is approved/merged and packages published I can continue with updates and this PR should be 1st

jpobst · 2022-01-27T19:59:11Z

config.json

+        "version": "1.0.0",
+        "nugetVersion": "1.0.0",
+        "nugetId": "Xamarin.AndroidX.Emoji2",
+        "excludedRuntimeDependencies": "androidx.lifecycle.lifecycle-process",


This seems to be an actual needed runtime dependency. Removing it will likely cause this package to not work:

<dependency> <groupId>androidx.lifecycle</groupId> <artifactId>lifecycle-process</artifactId> <version>2.4.0</version> <scope>runtime</scope> <type>aar</type> </dependency>

jpobst · 2022-01-27T20:20:23Z

config.json

        "artifactId": "kotlin-stdlib",
-        "version": "1.5.31",
-        "nugetVersion": "1.5.31.3",
+        "version": "1.6.0",


I think we need to hold off on updating Kotlin to 1.6.0. Looking at the diffs makes me think they may have changed how they are encoding their "unsigned" types, and we may need a fix there or else all of our Kotlin support around them will be incorrect.

Example: these changed from uint to int for a type called UIntArray:

Type Changed: Kotlin.UIntArray

Removed methods:

public static uint Get (int[] _this, int index); public static void Set (int[] _this, int index, uint value);

Added methods:

public static int Get (int[] arg0, int index); public static void Set (int[] arg0, int index, int value);

Seems like API was changed:

Type Changed: Kotlin.UByteArray

Removed methods:

public static byte Get (byte[] _this, int index); public static void Set (byte[] _this, int index, byte value); public virtual int Size ();

Decompiled:

public final class UByteArray implements Collection<UByte>, KMappedMarker { // removed public static final byte get-w2LRezQ(final byte[] arg0, final int index) { Intrinsics.checkNotNullParameter(arg0, "arg0"); return UByte.constructor-impl(arg0[index]); } public static final void set-VurrAj0(final byte[] arg0, final int index, final byte value) { Intrinsics.checkNotNullParameter(arg0, "arg0"); arg0[index] = value; } public static int getSize-impl(final byte[] arg0) { Intrinsics.checkNotNullParameter(arg0, "arg0"); return arg0.length; } public int getSize() { return getSize-impl(this.storage); } // removed }

Type Changed: Kotlin.UIntArray

Removed interfaces:

Java.Lang.IIterable Java.Util.ICollection

Removed methods:

public static uint Get (int[] _this, int index); public static void Set (int[] _this, int index, uint value); public virtual int Size ();

Decompiled:

public final class UIntArray implements Collection<UInt>, KMappedMarker { // removed public static final int get-pVg5ArA(final int[] arg0, final int index) { Intrinsics.checkNotNullParameter(arg0, "arg0"); return UInt.constructor-impl(arg0[index]); } public static final void set-VXSXFK8(final int[] arg0, final int index, final int value) { Intrinsics.checkNotNullParameter(arg0, "arg0"); arg0[index] = value; } // removed }

Type Changed: Kotlin.ULongArray

Removed methods:

public static ulong Get (long[] _this, int index); public static void Set (long[] _this, int index, ulong value); public virtual int Size ();

Decompiled:

public final class ULongArray implements Collection<ULong>, KMappedMarker { // removed public static final long get-s-VKNKU(final long[] arg0, final int index) { Intrinsics.checkNotNullParameter(arg0, "arg0"); return ULong.constructor-impl(arg0[index]); } public static final void set-k8EXiF4(final long[] arg0, final int index, final long value) { Intrinsics.checkNotNullParameter(arg0, "arg0"); arg0[index] = value; } public static int getSize-impl(final long[] arg0) { Intrinsics.checkNotNullParameter(arg0, "arg0"); return arg0.length; } public int getSize() { return getSize-impl(this.storage); } // removed }

Type Changed: Kotlin.UShortArray

Removed methods:

public static ushort Get (short[] _this, int index); public static void Set (short[] _this, int index, ushort value); public virtual int Size ();

Decompiled:

public final class UShortArray implements Collection<UShort>, KMappedMarker { // removed public static final short get-Mh2AYeg(final short[] arg0, final int index) { Intrinsics.checkNotNullParameter(arg0, "arg0"); return UShort.constructor-impl(arg0[index]); } public static final void set-01HTLdE(final short[] arg0, final int index, final short value) { Intrinsics.checkNotNullParameter(arg0, "arg0"); arg0[index] = value; } public static int getSize-impl(final short[] arg0) { Intrinsics.checkNotNullParameter(arg0, "arg0"); return arg0.length; } public int getSize() { return getSize-impl(this.storage); } // removed }

jpobst · 2022-01-27T20:26:07Z

config.json

        "artifactId": "activity",
        "version": "1.3.1",
-        "nugetVersion": "1.3.1.2",
+        "nugetVersion": "1.3.1.3",


There's about 20 artifacts that are bumping the nugetVersion but are not bumping the artifact version, What is this for?

I don't remember. It was begining of December. I might have rebased/merged some change from other PRs

Fixes: #945 Context: dotnet/android-libraries#436 (comment) Consider the following Kotlin function: fun get (index: Int) : UInt { … } When `get` is compiled with Kotlin 1.5, `class-parse` would emit: <method abstract="false" final="true" name="get-pVg5ArA" return="uint" jni-return="I" static="true" visibility="public" jni-signature="([II)I"> <parameter name="$this" type="int[]" jni-type="[I" /> <parameter name="index" type="int" jni-type="I" /> </method> However, when `get` is compiled with Kotlin 1.6, `class-parse` sees: <method abstract="false" final="true" name="get-pVg5ArA" return="int" jni-return="I" static="true" visibility="public" jni-signature="([II)I"> <parameter name="arg0" type="int[]" jni-type="[I" /> <parameter name="index" type="int" jni-type="I" /> </method> Note that the name of the first `int[]` parameter changes from `$this` to `arg0`, and the return type changed from `uint` to `int`. The parameter name change is annoying; the return type change is an ABI break, and makes many package updates impossible. What happened? Recall commit 71afce5: Kotlin-compiled `.class` files contain a `kotlin.Metadata` type-level annotation blob, which contains a Protobuf stream containing Kotlin metadata for the type. The `kotlin.Metadata` annotation contains information about Kotlin functions, and `class-parse` needs to associate the information about the Kotlin functions to Java methods. This can be tricky because there is not an explicit way to do this, and one must rely on trying to match function names and parameter types. Previously, this was accomplished by looping through the parameters and comparing types. However, the `kotlin.Metadata` annotation only includes "user created" method parameters, while the Java method may include "compiler created" method parameters. We attempted to skip these by ignoring Java parameters whose names begin with a dollar sign (ex `$this`). This "worked" most of the time. This broke in Kotlin 1.6, as the compiler generated method parameters stopped using `$` for compiler-generated parameter names. algorithm. We need something better. The `kKotlin.Metadata` annotation provides a `JvmSignature` property -- which matches the `JvmName` property which we already use -- which sounds promising. However, `JvmSignature` is sometimes `null`, and sometimes it doesn't actually match. But it's closer. So now we try to match with signatures. * If `JvmSignature` matches the Java signature we use that. * If `JvmSignature` is `null`, calculate it from the Kotlin parameters and try to match with that. * Note it wants unsigned types as `Lkotlin/UInt;` and not the primitive encoding (`I`). * If Kotlin metadata defines a `ReceiverType`, add that as the first parameter to the signature. Using `kotlin-stdlib-1.5.31.jar` as a baseline, we get much better results: | Version | Matched Functions | Unmatched Functions | | --------------- | ----------------: | --------------------: | | main @ 32635fd | 946 | 154 | | This PR | 1100 | 0 | Now that we can match Kotlin functions to Java methods, we still have to match up the parameters so we can apply parameter-level transforms. Do this by removing Java method parameters from the front and back of the list to account for cases where the compiler adds "hidden" parameters: * Remove Kotlin `ReceiverType` from beginning of list. * Remove Kotlin `Lkotlin/coroutines/Continuation;` from end of list. * Note this _could_ be a legitimate user supplied parameter so we try to restrict it to "unnamed" parameters. * Remove the `this` parameter added to `static` functions. Note: the test classes `DeepRecursiveKt.class`, `DeepRecursiveScope.class`, and `UByteArray.class` are pulled from [`kotlin-stdlib-1.5.31.jar`][0]. [0]: https://mvnrepository.com/artifact/org.jetbrains.kotlin/kotlin-stdlib/1.5.31

moljac added 7 commits December 3, 2021 17:25

Update config.json

0d85c72

mappings

d83bbaf

metadata new and fixes

de5f835

unit tests fixes

ebf531e

Update utilities.cake

b9a0f4c

Update dependencies.json

8355b0c

Merge branch 'main' into wsu-20211202

956a346

This was referenced Dec 9, 2021

Bind important missing compose stable packages #441

Merged

Moshi-1.13.0 xamarin/XamarinComponents#1309

Closed

moljac added 12 commits December 13, 2021 14:25

mappings updates

8479065

removed apis collection and open in editor

737b575

Update dependencies.json

e69008f

Update dependencies.json

c1c875e

downgraded artifacts that target SDK 31

c1a12ae

parsing pom and AndroidManifest.xml to detect targetSDKVersion

845a731

azure-pipelines.yml version bumps

670a598

targetSDKversion and minCompileSDK analysis

11f2a10

Merge branch 'main' into wsu-20211202

56fdcbc

Update config.json

9e1332e

mappings updates

7a8007b

Merge branch 'wsu-20211202' of https://github.com/xamarin/AndroidX in…

7fc38dd

…to wsu-20211202

moljac added 5 commits January 24, 2022 17:44

Merge branch 'main' into wsu-20211202

12db392

unit tests fixes

7961c8a

mappings updatesa

7b14e4b

Update dependencies.json

af18146

Update DependenciesTests.cs

f32b376

moljac requested a review from jpobst January 27, 2022 12:21

jpobst reviewed Jan 27, 2022

View reviewed changes

jpobst mentioned this pull request Jan 27, 2022

manual update mu 20211216 androidx.window:*-1.0.0(stable) #449

Merged

conceptdev mentioned this pull request Jan 27, 2022

Update "AndroidX.Window" to "1.0.0" stable release #470

Closed

moljac added 5 commits January 30, 2022 21:33

reverting some bumps

75ba724

Update androidx-assemblies.csv

8ca8c1a

version tuning for lifecycle packages

8551dd8

Update DependenciesTests.cs

62c1b84

mappings

65b3726

moljac requested a review from jpobst January 31, 2022 18:53

jpobst approved these changes Jan 31, 2022

View reviewed changes

moljac merged commit 2dc46c6 into main Jan 31, 2022

moljac deleted the wsu-20211202 branch January 31, 2022 20:00

jpobst mentioned this pull request Jan 31, 2022

Kotlin 1.6 metadata sometimes isn't applied dotnet/java-interop#945

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Weekly Stable Updates 20211202 #436

Weekly Stable Updates 20211202 #436

Uh oh!

moljac commented Dec 3, 2021 •

edited

Loading

Uh oh!

PawKanarek commented Jan 19, 2022

Uh oh!

moljac commented Jan 19, 2022

Uh oh!

jpobst Jan 27, 2022

Uh oh!

jpobst Jan 27, 2022

Uh oh!

moljac Jan 29, 2022

Uh oh!

jpobst Jan 27, 2022

Uh oh!

moljac Jan 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Weekly Stable Updates 20211202 #436

Weekly Stable Updates 20211202 #436

Uh oh!

Conversation

moljac commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updated aritfact bindings

Changed but not updated

Uh oh!

PawKanarek commented Jan 19, 2022

Uh oh!

moljac commented Jan 19, 2022

Uh oh!

jpobst Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

jpobst Jan 27, 2022

Choose a reason for hiding this comment

Type Changed: Kotlin.UIntArray

Uh oh!

moljac Jan 29, 2022

Choose a reason for hiding this comment

Type Changed: Kotlin.UByteArray

Type Changed: Kotlin.UIntArray

Type Changed: Kotlin.ULongArray

Type Changed: Kotlin.UShortArray

Uh oh!

jpobst Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

moljac Jan 29, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

moljac commented Dec 3, 2021 •

edited

Loading