Multi-target for .NET 6 and MonoAndroid90 #247

jonathanpeppers · 2021-01-25T19:44:56Z

Context: https://github.com/xamarin/Xamarin.Legacy.Sdk

This uses Xamarin.Legacy.Sdk to multi-target.

For this to work:

You have to use dotnet build to build any Xamarin.Legacy.Sdk
projects. Windows can use MSBuild.exe from Visual Studio 16.9
Preview 4 as well.

The CI build will also have to install:

.NET 6.0.100-preview.1.21103.13
Microsoft.NET.Android.Workload 11.0.200.50
Xamarin.Android 11.2.99.85

Other notes:

Class libraries had application properties set like
$(EnableProguard), $(AndroidEnableMultiDex),
$(AndroidDexTool), $(AndroidLinkTool), etc.

Context: dotnet/android-libraries#247 Context: https://github.com/xamarin/Xamarin.Legacy.Sdk I'm testing out if we can multi-target the AndroidX libraries for `MonoAndroid90;net6.0-android`. Unfortunately the build fails because: 1. The `UseDotNet@2` yaml task can't install .NET 6.0.100-alpha.1.21064.27. We have to use the `dotnet-install` script to install it ourselves. 2. `dotnet tool` commands won't work, if there is a `global.json` file targeting `6.0.100-alpha.1.21064.27`. I think for now, we should make it so callers can set `dotnet: ''` and skip many of these steps. Callers can also leave the `tools: []` parameter blank. If a build needs to install .NET 6 and other .NET global tools, I think it will be able to be done in `preBuildSteps` after these changes.

…r apps Context: dotnet/android-libraries#247 When porting AndroidX to .NET 6, I noticed something odd... I was getting `.aar` files in the build output that appeared to contain the contents of `android-support-multidex.jar`. Then I noticed: https://github.com/xamarin/AndroidX/blob/16b02ae51980f7bab7be395d44f9998eea9bf32f/source/AndroidXProject.cshtml#L18 The AndroidX binding projects are setting `$(AndroidEnableMultiDex)`? This is surely not intentional to be set in a class library, but this causes `_AddMultiDexDependencyJars` to run: <Target Name="_AddMultiDexDependencyJars">  <ItemGroup Condition=" '$(AndroidEnableMultiDex)' == 'True' AND '$(AndroidMultiDexSupportJar)' == '' "> <AndroidJavaLibrary Include="$(MonoAndroidToolsDirectory)\android-support-multidex.jar" /> </ItemGroup> </Target> If this was added to `@(AndroidJavaLibrary)`, then the `<CreateAar/>` MSBuild task would happily package it in a .NET 6 class library! I think the solution here is that the `_AddMultiDexDependencyJars` MSBuild target shouldn't actually run unless `$(AndroidApplication)` is `true`. I added updated an existing test for this scenario.

Context: dotnet/android-libraries#247 To improve upon the changes in abda726, we could add a new `initSteps` to install .NET 6. Previously, if we could only install .NET 6 during `preBuildSteps`, then the `dotnet tool` commands would fail: - pwsh: | dotnet tool install -g api-tools --version ${{ parameters.apiTools }} ... displayName: 'Install required .NET Core global tools' Because .NET 6 is defined in `global.json`, you would get an error saying there was no .NET 6 installed. If we add a new `initSteps`, we could do something like: initSteps: - pwsh: | $ProgressPreference = 'SilentlyContinue' Invoke-WebRequest -Uri "https://dot.net/v1/dotnet-install.ps1" -OutFile dotnet-install.ps1 & .\dotnet-install.ps1 -Version $(DotNet6Version) -InstallDir "$env:ProgramFiles\dotnet\" -Verbose tools: - 'xamarin.androidbinderator.tool': '0.4.2' - 'xamarin.androidx.migration.tool': '1.0.7.1' Then the `dotnet tool` commands will succeed.

azure-pipelines.yml

source/AndroidXProject.cshtml

Context: dotnet/android-libraries#247 To improve upon the changes in abda726, we could add a new `initSteps` to install .NET 6. Previously, if we could only install .NET 6 during `preBuildSteps`, then the `dotnet tool` commands would fail: - pwsh: | dotnet tool install -g api-tools --version ${{ parameters.apiTools }} ... displayName: 'Install required .NET Core global tools' Because .NET 6 is defined in `global.json`, you would get an error saying there was no .NET 6 installed. If we add a new `initSteps`, we could do something like: initSteps: - pwsh: | $ProgressPreference = 'SilentlyContinue' Invoke-WebRequest -Uri "https://dot.net/v1/dotnet-install.ps1" -OutFile dotnet-install.ps1 & .\dotnet-install.ps1 -Version $(DotNet6Version) -InstallDir "$env:ProgramFiles\dotnet\" -Verbose tools: - 'xamarin.androidbinderator.tool': '0.4.2' - 'xamarin.androidx.migration.tool': '1.0.7.1' Then the `dotnet tool` commands will succeed.

…r apps (#5548) Context: dotnet/android-libraries#247 When porting AndroidX to .NET 6, I noticed something odd... I was getting `.aar` files in the build output that appeared to contain the contents of `android-support-multidex.jar`. Then I noticed: https://github.com/xamarin/AndroidX/blob/16b02ae51980f7bab7be395d44f9998eea9bf32f/source/AndroidXProject.cshtml#L18 The AndroidX binding projects are setting `$(AndroidEnableMultiDex)`? This is surely not intentional to be set in a class library, but this causes `_AddMultiDexDependencyJars` to run: <Target Name="_AddMultiDexDependencyJars">  <ItemGroup Condition=" '$(AndroidEnableMultiDex)' == 'True' AND '$(AndroidMultiDexSupportJar)' == '' "> <AndroidJavaLibrary Include="$(MonoAndroidToolsDirectory)\android-support-multidex.jar" /> </ItemGroup> </Target> If this was added to `@(AndroidJavaLibrary)`, then the `<CreateAar/>` MSBuild task would happily package it in a .NET 6 class library! I think the solution here is that the `_AddMultiDexDependencyJars` MSBuild target shouldn't actually run unless `$(AndroidApplication)` is `true`. I added updated an existing test for this scenario.

moljac

LGTM

moljac · 2021-02-09T17:17:29Z

/azp run

azure-pipelines · 2021-02-09T17:17:46Z

Azure Pipelines successfully started running 1 pipeline(s).

Context: https://github.com/xamarin/Xamarin.Legacy.Sdk This uses Xamarin.Legacy.Sdk to multi-target. For this to work: * You have to use `dotnet build` to build any `Xamarin.Legacy.Sdk` projects. Windows can use `MSBuild.exe` from Visual Studio 16.9 Preview 4 as well. The CI build will also have to install: * .NET 6.0.100-preview.1.21103.13 * Microsoft.NET.Android.Workload 11.0.200.50 * Xamarin.Android 11.2.99.85 Other notes: * Class libraries had application properties set like `$(EnableProguard)`, `$(AndroidEnableMultiDex)`, `$(AndroidDexTool)`, `$(AndroidLinkTool)`, etc.

Context: https://github.com/dotnet/designs/blob/38bffe6c03a149c80f1c3b22787f33c794e71c76/accepted/2021/net6.0-tfms/net6.0-tfms.md We don't have a complete implementation for .NET 6 & NuGet yet, so for for things to work *at all* we have `Microsoft.Android.Sdk.NuGet.targets` that contains workarounds that enable: * Given some NuGet package, `Foo.nupkg` * Try `lib/net6.0-android/Foo.dll` * Try `lib/monoandroid10.0/Foo.dll`, other `$(TFV)` etc. We can now test the above scenario with AndroidX NuGet packages: * dotnet/android-libraries#247 * https://pkgs.dev.azure.com/azure-public/vside/_packaging/xamarin-impl/nuget/v3/index.json * `<PackageReference Include="Xamarin.AndroidX.AppCompat" Version = "1.2.0.7-net6preview01" />` Unfortunately, consuming `Xamarin.AndroidX.AppCompat` results in our build using `lib/monoandroid90/Xamarin.AndroidX.AppCompat.dll` over the .NET 6 one! I was able to reproduce this failure in the `XASdkTests.DotNetBuild()` test, as any `Release` build will fail during linking when using `MonoAndroid` assemblies without `KnownPackages.AddDotNetCompatPackages()`. To solve the problem, we need to list `net6.0-android30.0` in `$(PackageTargetFallback)`. Now .NET 6 packages are preferred over `MonoAndroid` ones. Lastly I added `MonoAndroid11.0`, because it was missing. Eventually I hope to delete `Microsoft.Android.Sdk.NuGet.targets` completely when the NuGet implementation of TFMs in .NET 6 is complete.

This PR is producing: Xamarin.AndroidX.AppCompat.Resources.1.1.0.1.nupkg So it failed to upload to the NuGet feed.

This PR is producing: Xamarin.AndroidX.Migration.1.0.8.nupkg Xamarin.AndroidX.Migration.Tool.1.0.8.nupkg So it failed to upload to the NuGet feed.

Context: xamarin/XamarinComponents#1111

I updated our AndroidX packages via: dotnet/android-libraries#247 The current build is based on the .NET 6 Preview 3 bits.

@deprecated

We have new AndroidX packages produced from: dotnet/android-libraries#247 After updating I ran into: C:\src\maui\src\Compatibility\Core\src\Android\CollectionView\SelectableViewHolder.cs(44,25): error CS0618: 'RecyclerView.ViewHolder.AdapterPosition' is obsolete: 'deprecated' [C:\src\maui\src\Compatibility\Core\src\Compatibility-net6.csproj] C:\src\maui\src\Compatibility\Core\src\Android\CollectionView\SelectableItemsViewAdapter.cs(70,9): error CS0618: 'RecyclerView.ViewHolder.AdapterPosition' is obsolete: 'deprecated' [C:\src\maui\src\Compatibility\Core\src\Compatibility-net6.csproj] 0 Warning(s) 2 Error(s) `AdapterPosition` is indeed obsolete: https://stackoverflow.com/a/63148812 It appears we can use `BindingAdapterPosition`, because the deprecated code is basically: @deprecated public final int getAdapterPosition() { return getBindingAdapterPosition(); }

Latest AndroidX packages coming from: dotnet/android-libraries#247 These AndroidX packages are based on the .NET 6 Preview 3 bits.

@deprecated

We have new AndroidX packages produced from: dotnet/android-libraries#247 After updating I ran into: C:\src\maui\src\Compatibility\Core\src\Android\CollectionView\SelectableViewHolder.cs(44,25): error CS0618: 'RecyclerView.ViewHolder.AdapterPosition' is obsolete: 'deprecated' [C:\src\maui\src\Compatibility\Core\src\Compatibility-net6.csproj] C:\src\maui\src\Compatibility\Core\src\Android\CollectionView\SelectableItemsViewAdapter.cs(70,9): error CS0618: 'RecyclerView.ViewHolder.AdapterPosition' is obsolete: 'deprecated' [C:\src\maui\src\Compatibility\Core\src\Compatibility-net6.csproj] 0 Warning(s) 2 Error(s) `AdapterPosition` is indeed obsolete: https://stackoverflow.com/a/63148812 It appears we can use `BindingAdapterPosition`, because the deprecated code is basically: @deprecated public final int getAdapterPosition() { return getBindingAdapterPosition(); }

jonathanpeppers · 2021-07-30T15:49:17Z

I think we can close this now, we have #340 merged.

Latest AndroidX packages coming from: dotnet/android-libraries#247 These AndroidX packages are based on the .NET 6 Preview 3 bits.

jonathanpeppers mentioned this pull request Jan 25, 2021

[azdo] make dotnet parameter optional xamarin/XamarinComponents#1081

Merged

dotnet deleted a comment from azure-pipelines bot Jan 26, 2021

jonathanpeppers mentioned this pull request Jan 26, 2021

[Xamarin.Android.Build.Tasks] _AddMultiDexDependencyJars only runs for apps dotnet/android#5548

Merged

jonathanpeppers mentioned this pull request Jan 26, 2021

[azdo] add initSteps for installing .NET 6 xamarin/XamarinComponents#1082

Merged

moljac reviewed Jan 27, 2021

View reviewed changes

azure-pipelines.yml Outdated Show resolved Hide resolved

moljac reviewed Jan 27, 2021

View reviewed changes

azure-pipelines.yml Outdated Show resolved Hide resolved

moljac reviewed Jan 27, 2021

View reviewed changes

source/AndroidXProject.cshtml Outdated Show resolved Hide resolved

moljac approved these changes Feb 9, 2021

View reviewed changes

moljac added the do-not-merge PR is still in progress and is not ready to be merged label Feb 9, 2021

jonathanpeppers mentioned this pull request Feb 10, 2021

NRE in generator dotnet/java-interop#797

Closed

jonathanpeppers mentioned this pull request Feb 23, 2021

[One .NET] update $(PackageTargetFallback) for NuGet packages dotnet/android#5654

Merged

moljac and others added 8 commits March 2, 2021 11:08

Lifecycle.Runtime fix for missing Core.Runtime dependency

f034c24

Bump to net6preview02

ce16add

Append $BUILD_BUILDID to $(PackageVersionSuffix)

bc15537

Fix Xamarin.AndroidX.AppCompat.Resources version

57ecf32

This PR is producing: Xamarin.AndroidX.AppCompat.Resources.1.1.0.1.nupkg So it failed to upload to the NuGet feed.

Fix Xamarin.AndroidX.Migration version

d7a82cb

This PR is producing: Xamarin.AndroidX.Migration.1.0.8.nupkg Xamarin.AndroidX.Migration.Tool.1.0.8.nupkg So it failed to upload to the NuGet feed.

Depend on .NET 6 Xamarin.Google.Guava.*

34ae555

Context: xamarin/XamarinComponents#1111

Merge remote-tracking branch 'upstream/master' into net6

ff609ec

Bump to .NET 6 Preview 3

9ba0322

Bump to net6preview03 NuGet version

79945fd

jonathanpeppers added a commit to dotnet/maui-samples that referenced this pull request Apr 22, 2021

Bump to AndroidX net6preview03

1037631

I updated our AndroidX packages via: dotnet/android-libraries#247 The current build is based on the .NET 6 Preview 3 bits.

jonathanpeppers mentioned this pull request Apr 22, 2021

Bump to AndroidX net6preview03 dotnet/maui-samples#138

Merged

jonathanpeppers mentioned this pull request Apr 22, 2021

Bump to new AndroidX packages dotnet/maui#825

Merged

12 tasks

jonathanpeppers added a commit to dotnet/maui-samples that referenced this pull request Apr 22, 2021

Bump to AndroidX net6preview03 (#138)

21e01da

Latest AndroidX packages coming from: dotnet/android-libraries#247 These AndroidX packages are based on the .NET 6 Preview 3 bits.

Add .NET 6 equivalent of LinkerSafe

9bfb0d2

jpobst mentioned this pull request Jul 14, 2021

[build] Convert to Xamarin.Legacy.Sdk. #339

Merged

jonathanpeppers closed this Jul 30, 2021

daniel1029-marker added a commit to daniel1029-marker/maui-samples that referenced this pull request Aug 24, 2025

Bump to AndroidX net6preview03 (#138)

f949323

Latest AndroidX packages coming from: dotnet/android-libraries#247 These AndroidX packages are based on the .NET 6 Preview 3 bits.

kenneth-charriez added a commit to kenneth-charriez/maui-samples that referenced this pull request Aug 25, 2025

Bump to AndroidX net6preview03 (#138)

3c0a1ca

Latest AndroidX packages coming from: dotnet/android-libraries#247 These AndroidX packages are based on the .NET 6 Preview 3 bits.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Multi-target for .NET 6 and MonoAndroid90 #247

Multi-target for .NET 6 and MonoAndroid90 #247

Uh oh!

jonathanpeppers commented Jan 25, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moljac left a comment

Uh oh!

moljac commented Feb 9, 2021

Uh oh!

azure-pipelines bot commented Feb 9, 2021

Uh oh!

jonathanpeppers commented Jul 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Multi-target for .NET 6 and MonoAndroid90 #247

Multi-target for .NET 6 and MonoAndroid90 #247

Uh oh!

Conversation

jonathanpeppers commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moljac left a comment

Choose a reason for hiding this comment

Uh oh!

moljac commented Feb 9, 2021

Uh oh!

azure-pipelines bot commented Feb 9, 2021

Uh oh!

jonathanpeppers commented Jul 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonathanpeppers commented Jan 25, 2021 •

edited

Loading