Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Jul 13, 2021

Context: #247

The first step in multi-targeting AndroidX with net6 is to migrate to Xamarin.Legacy.Sdk, which runs on top of .NET 6 but can build MonoAndroid9.0. We'll commit this first to help make it easier to run our diff logic on the resulting packages to make sure there are no regressions. A future commit will then enable net6.

Changes made:

  • CI - Install .NET 6 Preview 5
  • CI - Install the Android workload
  • Change Cake to use DotNetCore versions
  • Update Sdk to Xamarin.Legacy.Sdk

@jpobst jpobst force-pushed the xamarin-legacy-sdk branch 3 times, most recently from a8b6e94 to 4737b35 Compare July 13, 2021 19:28
@jpobst jpobst force-pushed the xamarin-legacy-sdk branch from 4737b35 to 071211e Compare July 13, 2021 20:44
@jpobst
Copy link
Contributor Author

jpobst commented Jul 14, 2021

The only differences seem to be:

  • Additional Framework Assembly References
  • PDB now contains Compiler Flags

All other files are the same.

I don't think these are issues, I simply raise them for reviewers to verify.

image

@jpobst jpobst marked this pull request as ready for review July 14, 2021 18:11
@jpobst jpobst requested review from jonathanpeppers and moljac July 14, 2021 18:11
@jonathanpeppers
Copy link
Member

The .pdb file looks like an improvement, probably caused by defaults in dotnet/sdk like $(Deterministic).

It doesn't seem like the extra framework references are an issue, maybe they are fine?

I think they are caused by:

https://github.com/xamarin/Xamarin.Legacy.Sdk/blob/f78e04e91651bf6a0021f0c5d483c150506d472e/src/Xamarin.Legacy.Sdk/Sdk/Xamarin.Legacy.Android.targets#L32-L40

So if you just put <Reference Include="Mono.Android"/> those show up.

@jpobst jpobst merged commit da540db into main Jul 16, 2021
@jpobst jpobst deleted the xamarin-legacy-sdk branch July 16, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants