This repository was archived by the owner on Jan 13, 2025. It is now read-only.
[azdo] make dotnet parameter optional #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android-libraries#247 Context: https://github.com/xamarin/Xamarin.Legacy.Sdk I'm testing out if we can multi-target the AndroidX libraries for `MonoAndroid90;net6.0-android`. Unfortunately the build fails because: 1. The `UseDotNet@2` yaml task can't install .NET 6.0.100-alpha.1.21064.27. We have to use the `dotnet-install` script to install it ourselves. 2. `dotnet tool` commands won't work, if there is a `global.json` file targeting `6.0.100-alpha.1.21064.27`. I think for now, we should make it so callers can set `dotnet: ''` and skip many of these steps. Callers can also leave the `tools: []` parameter blank. If a build needs to install .NET 6 and other .NET global tools, I think it will be able to be done in `preBuildSteps` after these changes.
mattleibow
approved these changes
Jan 25, 2021
|
I'm just going to merge this and try it out. It's possible I will need to change more here... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android-libraries#247
Context: https://github.com/xamarin/Xamarin.Legacy.Sdk
I'm testing out if we can multi-target the AndroidX libraries for
MonoAndroid90;net6.0-android.Unfortunately the build fails because:
The
UseDotNet@2yaml task can't install .NET6.0.100-alpha.1.21064.27. We have to use the
dotnet-installscript to install it ourselves.
dotnet toolcommands won't work, if there is aglobal.jsonfiletargeting
6.0.100-alpha.1.21064.27.I think for now, we should make it so callers can set
dotnet: ''andskip many of these steps. Callers can also leave the
tools: []parameter blank.
If a build needs to install .NET 6 and other .NET global tools, I
think it will be able to be done in
preBuildStepsafter thesechanges.