Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Jul 16, 2021

Add net6.0-android30.0 assemblies to AndroidX NuGets.

[assembly: AssemblyMetadata ("BUILD_NUMBER", "{BUILD_NUMBER}")]
[assembly: AssemblyMetadata ("BUILD_TIMESTAMP", "{BUILD_TIMESTAMP}")]

[assembly: Android.LinkerSafe]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[assembly: LinkerSafe] will be a warning in .NET 6:

https://github.com/xamarin/xamarin-android/blob/e4debf72015549e6e19cbfb247a47fead6ce7a01/src/Mono.Android/Android/LinkerSafeAttribute.cs#L5-L7

You could #if around it for .NET 6. But there are probably so many warnings, probably not seeing it anyway.

Copy link
Contributor Author

@jpobst jpobst Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think that warning isn't showing up yet since [LinkerSafe] won't be [Obsolete] until P7.

Wrapped it in #if !NETCOREAPP.

@jpobst jpobst marked this pull request as ready for review July 27, 2021 22:04
@jpobst jpobst requested a review from moljac July 27, 2021 22:05
Copy link
Contributor

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@jpobst jpobst merged commit 4d0e013 into main Jul 28, 2021
@jpobst jpobst deleted the multi-target branch July 28, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants