Don't show comment indication if you don't have permissions #4266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove pkg.json check * Remove unused imports
* Fix typo * Undo the requires change
* Default to esmodules * New packager * Fix edge case with handling exports * Test #1 * Test #2 * Test #2 * New try * Patch resolve in babel * Fix plugin * Logging * Remove esmodule check * Change fallback * Put check back * Remove isEsModule check code * Put convert esmodule code back in * Optimize for speed * Set a better default config * Simplify boolean * Set default babel configs
* Fix esm var changes * Fix object initiliazers * Add comment
CompuIves
commented
Jun 1, 2020
| ); | ||
| }); | ||
| } | ||
| Object.values(this.moduleModels).forEach(moduleModel => { |
Member
Author
There was a problem hiding this comment.
This one didn't really need a feature flag check.
christianalfoni
approved these changes
Jun 1, 2020
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
Looks good to me! 😄
Contributor
|
Build for latest commit 8a041a3 is at https://pr4266.build.csb.dev/s/new. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8463b03:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a041a3:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.