fix: check for vue router v4 #4203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a7c060:
|
Contributor
|
Build for latest commit 3a7c060 is at https://pr4203.build.csb.dev/s/new. |
Contributor
Author
|
I must have broken something because I can't get the script to execute: https://pr4203.build.csb.dev/s/bitter-sun-9x3d1?file=/index.html |
Contributor
|
yeah, something didn't like the change It breaks the new sandbox too Interesting https://pr4203.build.csb.dev/s/new |
Member
|
Maybe the PR build was broken, I can't think of any way how this could break all sandboxes. Could you try pushing another commit to force a rebuild? |
Member
|
This looks good now! The last failed test is a flaky test that's fixed on master 😄 |
Contributor
Author
|
@CompuIves I made a typo 🤦 #4263 |
CompuIves
pushed a commit
that referenced
this pull request
May 31, 2020
CompuIves
added a commit
that referenced
this pull request
Jun 1, 2020
* Added p5js icon * Remove unnecessary fill property * fix: setting undefined in URL (#4244) * Remove pkg.json check (#4248) * Remove pkg.json check * Remove unused imports * Add support for dynamic webpack loaders (#4245) * Fix typo * Undo the requires change * Fix eslint (#4259) * Resolve ESModules by default (#4191) * Default to esmodules * New packager * Fix edge case with handling exports * Test #1 * Test #2 * Test #2 * New try * Patch resolve in babel * Fix plugin * Logging * Remove esmodule check * Change fallback * Put check back * Remove isEsModule check code * Put convert esmodule code back in * Optimize for speed * Set a better default config * Simplify boolean * Set default babel configs * Fix links * Don't allow the sidebar to render if currentSandbox is not available (#4261) * fix: check for vue router v4 (#4203) * Fix esm var changes (#4262) * Fix esm var changes * Fix object initiliazers * Add comment * fix: typo in method isInsideVue (#4263) * Fix transforming properties like toString * Add comments data * Use unique id * Fix typo in reference Co-authored-by: Ives van Hoorne <[email protected]> Co-authored-by: Yash Joshi <[email protected]> Co-authored-by: Ives van Hoorne <[email protected]> Co-authored-by: Eduardo San Martin Morote <[email protected]>
CompuIves
added a commit
that referenced
this pull request
Jun 1, 2020
* Added p5js icon * Remove unnecessary fill property * fix: setting undefined in URL (#4244) * Remove pkg.json check (#4248) * Remove pkg.json check * Remove unused imports * Add support for dynamic webpack loaders (#4245) * Fix typo * Undo the requires change * Fix eslint (#4259) * Resolve ESModules by default (#4191) * Default to esmodules * New packager * Fix edge case with handling exports * Test #1 * Test #2 * Test #2 * New try * Patch resolve in babel * Fix plugin * Logging * Remove esmodule check * Change fallback * Put check back * Remove isEsModule check code * Put convert esmodule code back in * Optimize for speed * Set a better default config * Simplify boolean * Set default babel configs * Fix links * Don't allow the sidebar to render if currentSandbox is not available (#4261) * fix: check for vue router v4 (#4203) * Fix esm var changes (#4262) * Fix esm var changes * Fix object initiliazers * Add comment * fix: typo in method isInsideVue (#4263) * Fix transforming properties like toString * Add comments data * Use unique id * Fix typo in reference * Don't show comment indication if you don't have permission Co-authored-by: Danny Ruchtie <[email protected]> Co-authored-by: Yash Joshi <[email protected]> Co-authored-by: Eduardo San Martin Morote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This should fix hash routing in vue router v4 (https://n2qq4.csb.app/#/)
What is the current behavior?
Clicking on any link changes the url but does not trigger the click event
What is the new behavior?
Triggers the click event on the anchors
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist
There might be a better way to check if an element is inside of a Vue app, but I couldn't find anything better for Vue 3. Maybe @yyx990803 knows a better way