Skip to content

Conversation

@CompuIves
Copy link
Member

Fixes #3985

@CompuIves CompuIves force-pushed the add/webpack-loader-support branch from 579fe4d to f985074 Compare May 30, 2020 14:10
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 579fe4d:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented May 30, 2020

Build for latest commit 70e397e is at https://pr4245.build.csb.dev/s/new.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f985074:

Sandbox Source
Notifications Test Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 70e397e:

Sandbox Source
Notifications Test Configuration

@CompuIves CompuIves merged commit 56e3499 into master May 31, 2020
@CompuIves CompuIves deleted the add/webpack-loader-support branch May 31, 2020 16:06
CompuIves added a commit that referenced this pull request May 31, 2020
* Fix typo

* Undo the requires change
CompuIves added a commit that referenced this pull request Jun 1, 2020
* Added p5js icon

* Remove unnecessary fill property

* fix: setting undefined in URL (#4244)

* Remove pkg.json check (#4248)

* Remove pkg.json check

* Remove unused imports

* Add support for dynamic webpack loaders (#4245)

* Fix typo

* Undo the requires change

* Fix eslint (#4259)

* Resolve ESModules by default (#4191)

* Default to esmodules

* New packager

* Fix edge case with handling exports

* Test #1

* Test #2

* Test #2

* New try

* Patch resolve in babel

* Fix plugin

* Logging

* Remove esmodule check

* Change fallback

* Put check back

* Remove isEsModule check code

* Put convert esmodule code back in

* Optimize for speed

* Set a better default config

* Simplify boolean

* Set default babel configs

* Fix links

* Don't allow the sidebar to render if currentSandbox is not available (#4261)

* fix: check for vue router v4 (#4203)

* Fix esm var changes (#4262)

* Fix esm var changes

* Fix object initiliazers

* Add comment

* fix: typo in method isInsideVue (#4263)

* Fix transforming properties like toString

* Add comments data

* Use unique id

* Fix typo in reference

Co-authored-by: Ives van Hoorne <[email protected]>
Co-authored-by: Yash Joshi <[email protected]>
Co-authored-by: Ives van Hoorne <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>
CompuIves added a commit that referenced this pull request Jun 1, 2020
* Added p5js icon

* Remove unnecessary fill property

* fix: setting undefined in URL (#4244)

* Remove pkg.json check (#4248)

* Remove pkg.json check

* Remove unused imports

* Add support for dynamic webpack loaders (#4245)

* Fix typo

* Undo the requires change

* Fix eslint (#4259)

* Resolve ESModules by default (#4191)

* Default to esmodules

* New packager

* Fix edge case with handling exports

* Test #1

* Test #2

* Test #2

* New try

* Patch resolve in babel

* Fix plugin

* Logging

* Remove esmodule check

* Change fallback

* Put check back

* Remove isEsModule check code

* Put convert esmodule code back in

* Optimize for speed

* Set a better default config

* Simplify boolean

* Set default babel configs

* Fix links

* Don't allow the sidebar to render if currentSandbox is not available (#4261)

* fix: check for vue router v4 (#4203)

* Fix esm var changes (#4262)

* Fix esm var changes

* Fix object initiliazers

* Add comment

* fix: typo in method isInsideVue (#4263)

* Fix transforming properties like toString

* Add comments data

* Use unique id

* Fix typo in reference

* Don't show comment indication if you don't have permission

Co-authored-by: Danny Ruchtie <[email protected]>
Co-authored-by: Yash Joshi <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React project that works locally does not work in codesandbox

3 participants