Don't show comment indication if you don't have permissions (#4266)

* Added p5js icon

* Remove unnecessary fill property

* fix: setting undefined in URL (#4244)

* Remove pkg.json check (#4248)

* Remove pkg.json check

* Remove unused imports

* Add support for dynamic webpack loaders (#4245)

* Fix typo

* Undo the requires change

* Fix eslint (#4259)

* Resolve ESModules by default (#4191)

* Default to esmodules

* New packager

* Fix edge case with handling exports

* Test #1

* Test #2

* Test #2

* New try

* Patch resolve in babel

* Fix plugin

* Logging

* Remove esmodule check

* Change fallback

* Put check back

* Remove isEsModule check code

* Put convert esmodule code back in

* Optimize for speed

* Set a better default config

* Simplify boolean

* Set default babel configs

* Fix links

* Don't allow the sidebar to render if currentSandbox is not available (#4261)

* fix: check for vue router v4 (#4203)

* Fix esm var changes (#4262)

* Fix esm var changes

* Fix object initiliazers

* Add comment

* fix: typo in method isInsideVue (#4263)

* Fix transforming properties like toString

* Add comments data

* Use unique id

* Fix typo in reference

* Don't show comment indication if you don't have permission

Co-authored-by: Danny Ruchtie <[email protected]>
Co-authored-by: Yash Joshi <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>

Author: 4 people

packages/app/src/app/overmind/effects/vscode/ModelsHandler.ts

@@ -154,18 +154,16 @@ export class ModelsHandler {
   }
 
   public clearComments() {
-    if (this.sandbox.featureFlags.comments) {
-      Object.values(this.moduleModels).forEach(moduleModel => {
-        if (!moduleModel.model) {
-          return;
-        }
-        moduleModel.comments = [];
-        moduleModel.currentCommentDecorations = moduleModel.model.deltaDecorations(
-          moduleModel.currentCommentDecorations,
-          []
-        );
-      });
-    }
+    Object.values(this.moduleModels).forEach(moduleModel => {
+      if (!moduleModel.model) {
+        return;
+      }
+      moduleModel.comments = [];
+      moduleModel.currentCommentDecorations = moduleModel.model.deltaDecorations(
+        moduleModel.currentCommentDecorations,
+        []
+      );
+    });
   }
 
   public isModuleOpened(module: Module) {

packages/app/src/app/overmind/effects/vscode/index.ts

@@ -29,6 +29,7 @@ import * as childProcess from 'node-services/lib/child_process';
 import { TextOperation } from 'ot';
 import { json } from 'overmind';
 import io from 'socket.io-client';
+import { hasPermission } from '@codesandbox/common/lib/utils/permission';
 
 import { EXTENSIONS_LOCATION, VIM_EXTENSION_ID } from './constants';
 import {
@@ -1202,7 +1203,11 @@ export class VSCodeEffect {
 
       this.modelCursorPositionListener = activeEditor.onDidChangeCursorPosition(
         cursor => {
-          if (sandbox?.featureFlags.comments) {
+          if (
+            sandbox &&
+            sandbox.featureFlags.comments &&
+            hasPermission(sandbox.authorization, 'comment')
+          ) {
             const model = activeEditor.getModel();
 
             this.modelsHandler.updateLineCommentIndication(