Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jan 31, 2020

Follow-up of #2746, #2758, #2841, #2918, #3475, #3573, #3600, #3715 & #4226

Things I did extra:

  • Change itemIdChanged's signature to accept a string instead of { itemId: string }, because it only has 1 argument
  • Use FunctionComponent instead of React.FC, since it's the same, but FunctionComponent is a bit clearer I think
  • Type bindValue functions
  • Make Integrations & SideNavigation a FunctionComponent
  • Move overmind subscriptions as close as possible to the components itself instead of passing it through
  • Simplify PreferencesModal's getItems function so it doesn't render the components already when running it
  • Export PreferencesModal by a named export instead of a default export
  • Calculate the default value of comments within the useState function instead of using a useEffect in Comments expriment
  • Extract Card component out of PaymentInfo

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 31, 2020
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from d4810aa to 9a38b73 Compare January 31, 2020 01:39
@lbogdan lbogdan temporarily deployed to pr3429 January 31, 2020 01:44 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jan 31, 2020

Build for latest commit 19cc344 is at https://pr3429.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 9a38b73 to 333a36c Compare January 31, 2020 13:39
@lbogdan lbogdan temporarily deployed to pr3429 January 31, 2020 13:55 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch 2 times, most recently from 5ffaf31 to 55d88f1 Compare February 5, 2020 16:50
@lbogdan lbogdan temporarily deployed to pr3429 February 5, 2020 16:56 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 55d88f1 to 134b7dd Compare February 5, 2020 23:42
@lbogdan lbogdan temporarily deployed to pr3429 February 5, 2020 23:52 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 134b7dd to a9651f1 Compare February 8, 2020 12:37
@lbogdan lbogdan temporarily deployed to pr3429 February 8, 2020 12:53 Inactive
@SaraVieira
Copy link
Contributor

@MichaelDeBoey Can you please solve the conflicts?

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from a9651f1 to 3e6637f Compare February 13, 2020 13:45
@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira Rebased on upstream/master 🙂

@lbogdan lbogdan temporarily deployed to pr3429 February 13, 2020 13:51 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 3e6637f to 1f4a3aa Compare February 13, 2020 14:41
@lbogdan lbogdan temporarily deployed to pr3429 February 13, 2020 14:47 Inactive
@lbogdan lbogdan temporarily deployed to pr3429 February 13, 2020 15:34 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 7b936b1 to 6e10539 Compare February 13, 2020 18:21
@lbogdan lbogdan temporarily deployed to pr3429 February 13, 2020 18:28 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 6e10539 to 29e1311 Compare February 13, 2020 21:40
@lbogdan lbogdan temporarily deployed to pr3429 February 13, 2020 21:53 Inactive
@SaraVieira
Copy link
Contributor

Hey

If you click on something like experiments the whole thing collapses :(

Screenshot 2020-02-17 at 15 48 06

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 29e1311 to ab89c8d Compare February 18, 2020 17:56
@lbogdan lbogdan temporarily deployed to pr3429 February 18, 2020 18:02 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch 3 times, most recently from a3f3945 to 8dbb805 Compare April 23, 2020 23:36
@lbogdan lbogdan temporarily deployed to pr3429 April 23, 2020 23:42 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch 2 times, most recently from 8d20a4a to 03dd145 Compare April 23, 2020 23:47
@lbogdan lbogdan temporarily deployed to pr3429 April 23, 2020 23:54 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 03dd145 to fc0a458 Compare April 29, 2020 19:03
@lbogdan lbogdan temporarily deployed to pr3429 April 29, 2020 19:09 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from fc0a458 to 952dfcf Compare April 30, 2020 13:34
@lbogdan lbogdan temporarily deployed to pr3429 April 30, 2020 13:42 Inactive
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

Conflicts :(

Can you please not reorder attributes and imports? It makes it super hard to review the PR's as it looks away bigger than it is

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 952dfcf to f83bcdb Compare May 21, 2020 15:25
@MichaelDeBoey MichaelDeBoey requested a review from SaraVieira May 21, 2020 15:25
@lbogdan lbogdan temporarily deployed to pr3429 May 21, 2020 15:30 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19cc344:

Sandbox Source
Notifications Test Configuration

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch 2 times, most recently from 0969ae1 to e77f41f Compare July 2, 2020 22:56
@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira I've rebased onto upstream/master, so this could be merged now 🙂

@lbogdan lbogdan temporarily deployed to pr3429 July 2, 2020 23:04 Inactive
@lbogdan lbogdan temporarily deployed to pr3429 July 3, 2020 14:14 Inactive
@lbogdan lbogdan temporarily deployed to pr3429 July 3, 2020 14:26 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 3a2a21d to 6a234ff Compare July 3, 2020 14:30
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/PreferencesModal branch from 6a234ff to 19cc344 Compare July 3, 2020 14:36
@SaraVieira SaraVieira merged commit f8516ad into codesandbox:master Jul 3, 2020
@SaraVieira
Copy link
Contributor

Danke!!

@MichaelDeBoey MichaelDeBoey deleted the overmind/PreferencesModal branch July 3, 2020 15:13
@MichaelDeBoey
Copy link
Contributor Author

Always a pleasure! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants