-
Notifications
You must be signed in to change notification settings - Fork 2.4k
🔨 Switch PreferencesModal to use useOvermind #3429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Switch PreferencesModal to use useOvermind #3429
Conversation
d4810aa to
9a38b73
Compare
|
Build for latest commit 19cc344 is at https://pr3429.build.csb.dev/s/new. |
9a38b73 to
333a36c
Compare
5ffaf31 to
55d88f1
Compare
55d88f1 to
134b7dd
Compare
134b7dd to
a9651f1
Compare
|
@MichaelDeBoey Can you please solve the conflicts? |
a9651f1 to
3e6637f
Compare
|
@SaraVieira Rebased on |
3e6637f to
1f4a3aa
Compare
7b936b1 to
6e10539
Compare
6e10539 to
29e1311
Compare
29e1311 to
ab89c8d
Compare
a3f3945 to
8dbb805
Compare
8d20a4a to
03dd145
Compare
03dd145 to
fc0a458
Compare
fc0a458 to
952dfcf
Compare
SaraVieira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey!
Conflicts :(
Can you please not reorder attributes and imports? It makes it super hard to review the PR's as it looks away bigger than it is
952dfcf to
f83bcdb
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19cc344:
|
0969ae1 to
e77f41f
Compare
|
@SaraVieira I've rebased onto |
3a2a21d to
6a234ff
Compare
6a234ff to
19cc344
Compare
|
Danke!! |
|
Always a pleasure! 🙂 |

Follow-up of #2746, #2758, #2841, #2918, #3475, #3573, #3600, #3715 & #4226
Things I did extra:
itemIdChanged's signature to accept astringinstead of{ itemId: string }, because it only has 1 argumentFunctionComponentinstead ofReact.FC, since it's the same, butFunctionComponentis a bit clearer I thinkbindValuefunctionsIntegrations&SideNavigationaFunctionComponentovermindsubscriptions as close as possible to the components itself instead of passing it throughPreferencesModal'sgetItemsfunction so it doesn't render the components already when running itPreferencesModalby a named export instead of adefault exportcommentswithin theuseStatefunction instead of using auseEffectinCommentsexprimentCardcomponent out ofPaymentInfo