Skip to content

Conversation

@hetpatel33
Copy link
Contributor

@hetpatel33 hetpatel33 commented Oct 12, 2019

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni @SaraVieira

What is the current behavior?

/app/pages/common/Modals/PreferencesModal/index.js was using inject and hooksObserver from app/componentConnectors and written in JS.

What is the new behavior?

uses useOvermind hook from app/overmind and converted to tsx.

What steps did you take to test this? This is required before we can merge.

  1. Step A
  2. Step B
  3. Step C

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 12, 2019 12:07 Inactive
@vercel
Copy link

vercel bot commented Oct 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/fg5z15fte
🌍 Preview: https://codesandbox-cl-git-fork-hetpatel33-refactor-app-pages-co-2e659a.codesandbox1.now.sh

Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@CompuIves CompuIves merged commit 48cda52 into codesandbox:master Oct 12, 2019
@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants