Skip to content

Use feature flags instead of accessing localStorage directly #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2020
Merged

Use feature flags instead of accessing localStorage directly #3573

merged 3 commits into from
Feb 24, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Feb 24, 2020

@lbogdan lbogdan temporarily deployed to pr3573 February 24, 2020 17:45 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Feb 24, 2020 •
edited
Loading

Build for latest commit f54ccca is at https://pr3573.build.csb.dev/s/new.

SaraVieira
SaraVieira reviewed Feb 24, 2020
View reviewed changes
SaraVieira
SaraVieira suggested changes Feb 24, 2020
View reviewed changes
@lbogdan lbogdan temporarily deployed to pr3573 February 24, 2020 19:03 Inactive
@SaraVieira SaraVieira merged commit c7927cc into codesandbox:master Feb 24, 2020
@MichaelDeBoey MichaelDeBoey deleted the use-feature-flags branch February 24, 2020 23:03
@MichaelDeBoey MichaelDeBoey mentioned this pull request Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

@christianalfoni christianalfoni Awaiting requested review from christianalfoni

1 more reviewer

@SaraVieira SaraVieira SaraVieira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira