Skip to content

🔨 Refactor, 🧠 Overmind and hacktoberfest | changes done for app/pages/common/Modals/PreferencesModal/Experiments/index.tsx #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2019
Merged

🔨 Refactor, 🧠 Overmind and hacktoberfest | changes done for app/pages/common/Modals/PreferencesModal/Experiments/index.tsx #2918

merged 3 commits into from
Nov 5, 2019

Conversation

@22PoojaGaur
Copy link
Contributor

@22PoojaGaur 22PoojaGaur commented Oct 23, 2019

What kind of change does this PR introduce?

changing module to use typescript #2621

What is the current behavior?

What is the new behavior?

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Step A
  2. Step B
  3. Step C

Checklist

  • Documentation
  • Testing
  • [x ] Ready to be merged
  • Added myself to contributors table

@22PoojaGaur 22PoojaGaur mentioned this pull request Oct 23, 2019
Closed
84 tasks
@lbogdan
Copy link
Contributor

lbogdan commented Oct 23, 2019 •
edited
Loading

Build for latest commit f1f3878 is at https://pr2918.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr2918 October 23, 2019 22:56 Inactive
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 24, 2019
@SaraVieira
Copy link
Contributor

SaraVieira commented Oct 24, 2019

Awesome!!
Thank you so much!!

@22PoojaGaur
Copy link
Contributor Author

22PoojaGaur commented Oct 29, 2019 •
edited
Loading

can someone please re-run the circleci:test-jet again?
The test fails for jest: failed to cache transform results in: /tmp/jest_2ne/jest-transform-cache-e793b653da3927ae4eb913dc4de1e397-d0e7c439bf6eb5a4bf3a6371fdd259d1/8a/parse_8a7c50111c873c07feadfac518262bba Failure message: ENOMEM: not enough memory, write
So maybe it's not because of this PR.

CompuIves
CompuIves approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me! Merging now...

@CompuIves CompuIves merged commit 7f7e7d1 into codesandbox:master Nov 5, 2019
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CompuIves CompuIves CompuIves approved these changes

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@22PoojaGaur @lbogdan @SaraVieira @CompuIves @Saeris