🔨 Refactored, Hacktober | Refactor app/src/app/pages/common/Modals/MoveSandboxFolderModal/index.js to Typescript #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineoo
changed the title
Member
|
Thanks for the contribution!! Master was quite broken a moment ago, could you merge with |
christineoo
force-pushed
the
christineoo/convert-MoveSandboxFolderModal-to-ts
branch
from
9e0e9c7 to
41df949
Compare
Contributor
Author
|
Thanks for letting me know~! |
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A follow-up PR from #2751. This PR converts app/src/app/pages/common/Modals/MoveSandboxFolderModal/index.js to Typescript.
4899b90: rename file extension packages/app/src/app/pages/common/Modals/MoveSandboxFolderModal/index.js → packages/app/src/app/pages/common/Modals/MoveSandboxFolderModal/index.tsx
b52e674: change to use
styleinstead ofcsswhen styling the component9aee503: rename file extensionpackages/app/src/app/pages/common/Modals/MoveSandboxFolderModal/elements.js → packages/app/src/app/pages/common/Modals/MoveSandboxFolderModal/elements.ts
6bd61ff: Handle the
rightprops for<Block9e0e9c7: Remove the unnecessary interface definition
What is the current behavior?
MoveSandboxFolderModalis written in Javascript.What is the new behavior?
MoveSandboxFolderModalis written in Typescript.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist