Skip to content

🔨 Refactored, Hacktober | Refactor app/src/app/pages/common/Modals/MoveSandboxFolderModal/index.js to Typescript #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2019
Merged

🔨 Refactored, Hacktober | Refactor app/src/app/pages/common/Modals/MoveSandboxFolderModal/index.js to Typescript #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87e619b
rename file ext to .tsx
christineoo Oct 17, 2019
67a6a35
fix type error - refactor to use style
christineoo Oct 17, 2019
618fec0
change file ext to ts
christineoo Oct 17, 2019
91ed378
fix type error - add optional prop
christineoo Oct 17, 2019
41df949
remove the unnecessary interface definition
christineoo Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Modals/MoveSandboxFolderModal/elements.js → ...Modals/MoveSandboxFolderModal/elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import styled, { css } from 'styled-components';

export const Block = styled.div`
export const Block = styled.div<{ right?: boolean }>`
background-color: ${props => props.theme.background2};
color: rgba(255, 255, 255, 0.9);
padding: 1rem 1.5rem;
Expand Down
7 changes: 4 additions & 3 deletions ...on/Modals/MoveSandboxFolderModal/index.js → ...n/Modals/MoveSandboxFolderModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const MoveSandboxFolderModal = () => {
return (
<div>
<Block>Move to Folder</Block>
<Container css={{ maxHeight: 400, overflow: 'auto' }}>
<Container style={{ maxHeight: 400, overflow: 'auto' }}>
<DirectoryPicker
onSelect={onSelect}
currentTeamId={teamId}
Expand All @@ -72,7 +72,7 @@ const MoveSandboxFolderModal = () => {

<Button
onClick={handleMove}
css={{ display: 'inline-flex', alignItems: 'center' }}
style={{ display: 'inline-flex', alignItems: 'center' }}
small
disabled={loading}
>
Expand All @@ -85,7 +85,7 @@ const MoveSandboxFolderModal = () => {
? basename(path)
: `${teamId ? 'Our' : 'My'} Sandboxes`}
<ChevronRight
css={{ marginRight: '-.25rem', marginLeft: '.25rem' }}
style={{ marginRight: '-.25rem', marginLeft: '.25rem' }}
/>
</>
)}
Expand All @@ -95,4 +95,5 @@ const MoveSandboxFolderModal = () => {
);
};

// eslint-disable-next-line import/no-default-export
export default MoveSandboxFolderModal;