Skip to content

🔨 Switch MoveSandboxFolderModal to use useOvermind #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

🔨 Switch MoveSandboxFolderModal to use useOvermind #3446

merged 1 commit into from
Feb 13, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Feb 1, 2020

Follow-up of #2751 & #2830

Things I did extra:

  • Cleanup refetchSandboxInfo
  • Put all styles into the elements.ts file
  • Extract TeamsPicker from DirectoryPicker
  • Use @apollo/react-hooks' useQuery instead of react-apollo's Query
  • Make MoveSandboxFolderModal a FunctionComponent
  • Remove useCallback from handleMove & onSelect , since it's not necessary
  • Export MoveSandboxFolderModal by a named export instead of a default export

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Feb 1, 2020
@lbogdan lbogdan temporarily deployed to pr3446 February 1, 2020 16:50 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Feb 1, 2020 •
edited
Loading

Build for latest commit 869fb6d is at https://pr3446.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/MoveSandboxFolderModal branch from d3e7f12 to 739e493 Compare February 5, 2020 16:55
@lbogdan lbogdan temporarily deployed to pr3446 February 5, 2020 17:03 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/MoveSandboxFolderModal branch from 739e493 to 8af65b6 Compare February 5, 2020 23:47
@lbogdan lbogdan temporarily deployed to pr3446 February 5, 2020 23:58 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/MoveSandboxFolderModal branch from 8af65b6 to 869fb6d Compare February 8, 2020 12:40
@SaraVieira
Copy link
Contributor

SaraVieira commented Feb 13, 2020

Looks good! Thank you so much!

@SaraVieira SaraVieira merged commit aefd73b into codesandbox:master Feb 13, 2020
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Feb 13, 2020

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/MoveSandboxFolderModal branch February 13, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

@christianalfoni christianalfoni Awaiting requested review from christianalfoni

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira