Skip to content

Conversation

@MihirGH
Copy link
Contributor

@MihirGH MihirGH commented Oct 12, 2019

🔨 Refactored, 🧠 Overmind, Hacktober | Refactor MoveSandboxFolderModal to use overmind

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni @SaraVieira

What is the current behavior?

app/pages/common/Modals/MoveSandboxFolderModal/index.js was using inject and hookObserver from app/componentConnectors and also it was a class component with no lifecycle methods

What is the new behavior?

Refactored MoveSandboxFolderModal to FC and replaced inject, hookObserver with useOvermind

What steps did you take to test this? This is required before we can merge.

  1. Checked whether the folder is changed as expected by opening the modal when clicked on the label before the name of the sandbox.
  2. Ran yarn lint
  3. Ran yarn test

Checklist

  • Documentation: N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 12, 2019 16:10 Inactive
@vercel
Copy link

vercel bot commented Oct 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/cyah234h0
🌍 Preview: https://codesandbox-cl-git-fork-mihirgh-refactor-movesandboxfold-f8bf9a.codesandbox1.now.sh

Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great!! Thanks a bunch! Also thanks for testing the component, that really helped me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants