Skip to content

Conversation

@sakthivel-pro
Copy link
Contributor

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni @SaraVieira

What is the current behavior?

/Sandboxes/Filters/FilterOptions/index.tsx was using inject and observer from app/componentConnectors

What is the new behavior?

uses useOvermind from app/overmind

What steps did you take to test this?

ran yarn lint and yarn typecheck

Checklist

  • Documentation N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

…ns/index.tsx : Refactor to replace Cerebral with Overmind
@vercel vercel bot temporarily deployed to staging October 4, 2019 12:27 Inactive
@vercel
Copy link

vercel bot commented Oct 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-clien-git-fork-sakthivel-tw-refactor-filter-d01090.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 5, 2019 00:42 Inactive
@sakthivel-pro
Copy link
Contributor Author

@Saeris @christianalfoni @SaraVieira Couldn't add labels or reviewers to this pull request.

Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thank you!

@SaraVieira SaraVieira merged commit 438884a into codesandbox:master Oct 5, 2019
@SaraVieira
Copy link
Contributor

@all-contributors-bot please add sakthivel-tw for code

@allcontributors
Copy link
Contributor

@SaraVieira

I've put up a pull request to add @Sakthivel! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants