Skip to content

Conversation

@sakthivel-pro
Copy link
Contributor

@sakthivel-pro sakthivel-pro commented Oct 12, 2019

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni @SaraVieira

What is the current behavior?

/app/pages/Dashboard/Sidebar/TemplateItem/TemplateItem.tsx was using inject and observer from app/componentConnectors

What is the new behavior?

No reference to signals or store from inject and removed the dependencies.

What steps did you take to test this? This is required before we can merge.

ran yarn lint and yarn typecheck

Checklist

…Item/TemplateItem.tsx : refactor to remove Cerebral
@vercel
Copy link

vercel bot commented Oct 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/cl5qgouug
🌍 Preview: https://codesandbox-client-git-fork-sakthivel-tw-refactor-template-item.codesandbox1.now.sh

@CompuIves
Copy link
Member

Interesting! So we injected signals and store but we didn't use it? cc @christianalfoni @SaraVieira

@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 13, 2019
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! Looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants