Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Resubmission of #2857

Follow-up of #2650

Things I did extra:

  • Change blacklistedTemplateAdded & blacklistedTemplateRemoved's signatures to accept a string instead of { template: string }, because they only have 1 argument
  • Change blacklistedTemplatesChanged's signature to accept a string[] instead of { templates: string[] }, because it only has 1 argument
  • Put all styles into the elements.ts file
  • Export FilterOptions by a named export instead of a default export
  • Derive Filters' props type from child components
  • Derive Content's props type from child components
  • Delete types.ts and make Template a private type from FilterOptions

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Dec 16, 2019
@lbogdan lbogdan temporarily deployed to pr3216 December 16, 2019 17:03 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Dec 16, 2019

Build for latest commit 5e32256 is at https://pr3216.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3216 December 16, 2019 17:15 Inactive
@SaraVieira SaraVieira merged commit 82f81a0 into codesandbox:master Dec 30, 2019
@MichaelDeBoey MichaelDeBoey deleted the overmind/FilterOptions branch December 31, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants