Skip to content

🔨 Refactored 🧠 Overmind Hacktober | /app/pages/Dashboard/Content/Sandboxes/Filters/FilterOptions/index.tsx : refactor to replace Cerebral with Overmind #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2019
Merged

🔨 Refactored 🧠 Overmind Hacktober | /app/pages/Dashboard/Content/Sandboxes/Filters/FilterOptions/index.tsx : refactor to replace Cerebral with Overmind #2650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab5e3e
Refactored /app/pages/Dashboard/Content/Sandboxes/Filters/FilterOptio…
Oct 4, 2019
2ef0b7f
Merge branch 'master' of https://github.com/codesandbox/codesandbox-c…
Oct 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 26 additions & 20 deletions packages/app/src/app/pages/Dashboard/Content/Sandboxes/Filters/FilterOptions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,51 @@
import React from 'react';
import { orderBy } from 'lodash-es';
import { inject, observer } from 'app/componentConnectors';
import { useOvermind } from 'app/overmind';
import { Overlay as OverlayComponent } from 'app/components/Overlay';
import { Container, TemplatesName, OverlayContainer } from './elements';
import { Option } from './Option';
import { ITemplate } from '../../types';

interface Props {
interface IFilterOptionsProps {
possibleTemplates: ITemplate[];
hideFilters?: boolean;
store?: any;
signals?: any;
}

const FilterOptionsComponent = ({
const FilterOptionsComponent: React.FC<IFilterOptionsProps> = ({
possibleTemplates,
hideFilters,
store,
signals,
}: Props) => {
}: IFilterOptionsProps) => {
const {
state: {
dashboard: { isTemplateSelected, filters },
},
actions: {
dashboard: {
blacklistedTemplateAdded,
blacklistedTemplateRemoved,
blacklistedTemplatesCleared,
blacklistedTemplatesChanged,
},
},
} = useOvermind();

const toggleTemplate = (name: string, select: boolean) =>
select
? signals.dashboard.blacklistedTemplateRemoved({
? blacklistedTemplateRemoved({
template: name,
})
: signals.dashboard.blacklistedTemplateAdded({
: blacklistedTemplateAdded({
template: name,
});

const allSelected = possibleTemplates.every(t =>
store.dashboard.isTemplateSelected(t.id)
);
const allSelected = possibleTemplates.every(t => isTemplateSelected(t.id));

const Overlay = () => (
<OverlayContainer>
{possibleTemplates.length > 0 ? (
<>
{orderBy(possibleTemplates, 'niceName').map(template => {
const selected = store.dashboard.isTemplateSelected(template.id);
const selected = isTemplateSelected(template.id);

return (
<Option
Expand All @@ -54,9 +62,9 @@ const FilterOptionsComponent = ({
<Option
toggleTemplate={() => {
if (!allSelected) {
signals.dashboard.blacklistedTemplatesCleared();
blacklistedTemplatesCleared();
} else {
signals.dashboard.blacklistedTemplatesChanged({
blacklistedTemplatesChanged({
templates: possibleTemplates.map(t => t.id) || [],
});
}
Expand All @@ -74,7 +82,7 @@ const FilterOptionsComponent = ({
</OverlayContainer>
);

const { blacklistedTemplates } = store.dashboard.filters;
const { blacklistedTemplates } = filters;
const templateCount = possibleTemplates.length - blacklistedTemplates.length;
const templateMessage =
templateCount === possibleTemplates.length && templateCount > 0
Expand All @@ -95,6 +103,4 @@ const FilterOptionsComponent = ({
);
};

export const FilterOptions = inject('store', 'signals')(
observer(FilterOptionsComponent)
);
export const FilterOptions = FilterOptionsComponent;