Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Aug 31, 2016

What changes were proposed in this pull request?

SPARK-15373 (#13158) updated the version of vis.js to 4.16.1. As of 4.0.0, some class was renamed like 'timeline to vis-timeline' but that ticket didn't care and now style is broken.

In this PR, I've restored the style by modifying timeline-view.css and timeline-view.js.

How was this patch tested?

manual tests.

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

  • Before
    2016-09-01 1 38 31
  • After
    2016-09-01 3 30 19

@robert3005
Copy link

have you seen #14791 ? Should fix the biggest offender but full clean up is definitely useful

@srowen
Copy link
Member

srowen commented Aug 31, 2016

@sarutak can you connect this to your JIRA in the title?

@SparkQA
Copy link

SparkQA commented Aug 31, 2016

Test build #64728 has finished for PR 14900 at commit d32d1e1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak sarutak changed the title [WEBUI] Style of event timeline is broken [WEBUI][SPARK-17342] Style of event timeline is broken Aug 31, 2016
@sarutak
Copy link
Member Author

sarutak commented Aug 31, 2016

@robert3005 Thanks for the information. I think the PR you informed me still doesn't restore the style to what it was.

@srowen Thanks, I forgot to do it. I've connected to corresponding JIRA.

@sarutak
Copy link
Member Author

sarutak commented Aug 31, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 1, 2016

Test build #64738 has finished for PR 14900 at commit d32d1e1.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Sep 1, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 1, 2016

Test build #64748 has finished for PR 14900 at commit d32d1e1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 1, 2016

Test build #64749 has finished for PR 14900 at commit d32d1e1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Sep 1, 2016

LGTM. In light of this change, was #14791 necessary, or at least still a valid change?

@sarutak
Copy link
Member Author

sarutak commented Sep 1, 2016

@srowen Actually, I don't think that change is necessary because an existing setting encompasses that change added in #14791 .

@SparkQA
Copy link

SparkQA commented Sep 1, 2016

Test build #64807 has finished for PR 14900 at commit c4ad6a1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Sep 2, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 2, 2016

Test build #64820 has finished for PR 14900 at commit c4ad6a1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Sep 2, 2016
## What changes were proposed in this pull request?

SPARK-15373 (#13158) updated the version of vis.js to 4.16.1. As of 4.0.0, some class was renamed like 'timeline to vis-timeline' but that ticket didn't care and now style is broken.

In this PR, I've restored the style by modifying `timeline-view.css` and `timeline-view.js`.

## How was this patch tested?

manual tests.

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

* Before
<img width="1258" alt="2016-09-01 1 38 31" src="https://cloud.githubusercontent.com/assets/4736016/18141311/fddf1bac-6ff3-11e6-935f-28b389073b39.png">

* After
<img width="1256" alt="2016-09-01 3 30 19" src="https://cloud.githubusercontent.com/assets/4736016/18141394/49af65dc-6ff4-11e6-8640-70e20300f3c3.png">

Author: Kousuke Saruta <[email protected]>

Closes #14900 from sarutak/SPARK-17342.

(cherry picked from commit 2ab8dbd)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member

srowen commented Sep 2, 2016

Merged to master/2.0

@asfgit asfgit closed this in 2ab8dbd Sep 2, 2016
@sarutak sarutak deleted the SPARK-17342 branch June 4, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants