-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[WEBUI][SPARK-17342] Style of event timeline is broken #14900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
have you seen #14791 ? Should fix the biggest offender but full clean up is definitely useful |
|
@sarutak can you connect this to your JIRA in the title? |
|
Test build #64728 has finished for PR 14900 at commit
|
|
@robert3005 Thanks for the information. I think the PR you informed me still doesn't restore the style to what it was. @srowen Thanks, I forgot to do it. I've connected to corresponding JIRA. |
|
retest this please. |
|
Test build #64738 has finished for PR 14900 at commit
|
|
retest this please. |
|
Test build #64748 has finished for PR 14900 at commit
|
|
Test build #64749 has finished for PR 14900 at commit
|
|
LGTM. In light of this change, was #14791 necessary, or at least still a valid change? |
|
@srowen Actually, I don't think that change is necessary because an existing setting encompasses that change added in #14791 . |
|
Test build #64807 has finished for PR 14900 at commit
|
|
retest this please. |
|
Test build #64820 has finished for PR 14900 at commit
|
## What changes were proposed in this pull request? SPARK-15373 (#13158) updated the version of vis.js to 4.16.1. As of 4.0.0, some class was renamed like 'timeline to vis-timeline' but that ticket didn't care and now style is broken. In this PR, I've restored the style by modifying `timeline-view.css` and `timeline-view.js`. ## How was this patch tested? manual tests. (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) * Before <img width="1258" alt="2016-09-01 1 38 31" src="https://cloud.githubusercontent.com/assets/4736016/18141311/fddf1bac-6ff3-11e6-935f-28b389073b39.png"> * After <img width="1256" alt="2016-09-01 3 30 19" src="https://cloud.githubusercontent.com/assets/4736016/18141394/49af65dc-6ff4-11e6-8640-70e20300f3c3.png"> Author: Kousuke Saruta <[email protected]> Closes #14900 from sarutak/SPARK-17342. (cherry picked from commit 2ab8dbd) Signed-off-by: Sean Owen <[email protected]>
|
Merged to master/2.0 |
What changes were proposed in this pull request?
SPARK-15373 (#13158) updated the version of vis.js to 4.16.1. As of 4.0.0, some class was renamed like 'timeline to vis-timeline' but that ticket didn't care and now style is broken.
In this PR, I've restored the style by modifying
timeline-view.cssandtimeline-view.js.How was this patch tested?
manual tests.
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)