Skip to content

[WEBUI][SPARK-17342] Style of event timeline is broken #14900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WEBUI][SPARK-17342] Style of event timeline is broken #14900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d32d1e1
Fixed stylesheet to make adjustment to vis.js-4.16.1
sarutak Aug 31, 2016
c4ad6a1
Removed unnecessary style rule
sarutak Sep 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 28 additions & 29 deletions core/src/main/resources/org/apache/spark/ui/static/timeline-view.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,15 @@ div#application-timeline, div#job-timeline {
height: 55px;
}

#task-assignment-timeline div.item.range {
padding: 0px;
#task-assignment-timeline div.vis-item.vis-range {
height: 26px;
border-width: 0;
}

#task-assignment-timeline .vis-item-content {
padding: 0px;
}

.task-assignment-timeline-content {
width: 100%;
}
Expand Down Expand Up @@ -83,28 +86,24 @@ rect.getting-result-time-proportion {
stroke: #75B0A6;
}

.vis-item .vis-item-content {
width: 100%
}

.vis.timeline {
.vis-timeline {
line-height: 14px;
}

.vis.timeline div.content {
.vis-timeline div.vis-item-content {
width: 100%;
}

.vis.timeline .item.stage {
.vis-timeline .vis-item.stage {
cursor: pointer;
}

.vis.timeline .item.stage.succeeded {
.vis-timeline .vis-item.stage.succeeded {
background-color: #A0DFFF;
border-color: #3EC0FF;
}

.vis.timeline .item.stage.succeeded.selected {
.vis-timeline .vis-item.stage.succeeded.vis-selected {
background-color: #A0DFFF;
border-color: #3EC0FF;
z-index: auto;
Expand All @@ -115,12 +114,12 @@ rect.getting-result-time-proportion {
stroke: #3EC0FF;
}

.vis.timeline .item.stage.failed {
.vis-timeline .vis-item.stage.failed {
background-color: #FFA1B0;
border-color: #FF4D6D;
}

.vis.timeline .item.stage.failed.selected {
.vis-timeline .vis-item.stage.failed.vis-selected {
background-color: #FFA1B0;
border-color: #FF4D6D;
z-index: auto;
Expand All @@ -131,12 +130,12 @@ rect.getting-result-time-proportion {
stroke: #FF4D6D;
}

.vis.timeline .item.stage.running {
.vis-timeline .vis-item.stage.running {
background-color: #A2FCC0;
border-color: #36F572;
}

.vis.timeline .item.stage.running.selected {
.vis-timeline .vis-item.stage.running.vis-selected {
background-color: #A2FCC0;
border-color: #36F572;
z-index: auto;
Expand All @@ -147,20 +146,20 @@ rect.getting-result-time-proportion {
stroke: #36F572;
}

.vis.timeline .foreground {
.vis-timeline .vis-foreground {
cursor: move;
}

.vis.timeline .item.job {
.vis-timeline .vis-item.job {
cursor: pointer;
}

.vis.timeline .item.job.succeeded {
.vis-timeline .vis-item.job.succeeded {
background-color: #A0DFFF;
border-color: #3EC0FF;
}

.vis.timeline .item.job.succeeded.selected {
.vis-timeline .vis-item.job.succeeded.vis-selected {
background-color: #A0DFFF;
border-color: #3EC0FF;
z-index: auto;
Expand All @@ -171,12 +170,12 @@ rect.getting-result-time-proportion {
stroke: #3EC0FF;
}

.vis.timeline .item.job.failed {
.vis-timeline .vis-item.job.failed {
background-color: #FFA1B0;
border-color: #FF4D6D;
}

.vis.timeline .item.job.failed.selected {
.vis-timeline .vis-item.job.failed.vis-selected {
background-color: #FFA1B0;
border-color: #FF4D6D;
z-index: auto;
Expand All @@ -187,12 +186,12 @@ rect.getting-result-time-proportion {
stroke: #FF4D6D;
}

.vis.timeline .item.job.running {
.vis-timeline .vis-item.job.running {
background-color: #A2FCC0;
border-color: #36F572;
}

.vis.timeline .item.job.running.selected {
.vis-timeline .vis-item.job.running.vis-selected {
background-color: #A2FCC0;
border-color: #36F572;
z-index: auto;
Expand All @@ -203,7 +202,7 @@ rect.getting-result-time-proportion {
stroke: #36F572;
}

.vis.timeline .item.executor.added {
.vis-timeline .vis-item.executor.added {
background-color: #A0DFFF;
border-color: #3EC0FF;
}
Expand All @@ -213,7 +212,7 @@ rect.getting-result-time-proportion {
stroke: #3EC0FF;
}

.vis.timeline .item.executor.removed {
.vis-timeline .vis-item.executor.removed {
background-color: #FFA1B0;
border-color: #FF4D6D;
}
Expand All @@ -223,7 +222,7 @@ rect.getting-result-time-proportion {
stroke: #FF4D6D;
}

.vis.timeline .item.executor.selected {
.vis-timeline .vis-item.executor.vis-selected {
background-color: #A2FCC0;
border-color: #36F572;
z-index: 2;
Expand Down Expand Up @@ -262,15 +261,15 @@ span.expand-task-assignment-timeline {
cursor: pointer;
}

.vis.timeline .item.range .content {
.vis-timeline .vis-item.vis-range .vis-item-content {
position: unset;
}

.vis.timeline .item .tooltip-inner {
.vis-timeline .vis-item .tooltip-inner {
max-width: unset !important;
}

.vispanel.center {
.vis-panel.vis-center {
font-size: 12px;
line-height: 12px;
}
Expand Down
6 changes: 3 additions & 3 deletions core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function drawApplicationTimeline(groupArray, eventObjArray, startTime, offset) {
setupExecutorEventAction();

function setupJobEventAction() {
$(".item.range.job.application-timeline-object").each(function() {
$(".vis-item.vis-range.job.application-timeline-object").each(function() {
var getSelectorForJobEntry = function(baseElem) {
var jobIdText = $($(baseElem).find(".application-timeline-content")[0]).text();
var jobId = jobIdText.match("\\(Job (\\d+)\\)$")[1];
Expand Down Expand Up @@ -116,7 +116,7 @@ function drawJobTimeline(groupArray, eventObjArray, startTime, offset) {
setupExecutorEventAction();

function setupStageEventAction() {
$(".item.range.stage.job-timeline-object").each(function() {
$(".vis-item.vis-range.stage.job-timeline-object").each(function() {
var getSelectorForStageEntry = function(baseElem) {
var stageIdText = $($(baseElem).find(".job-timeline-content")[0]).text();
var stageIdAndAttempt = stageIdText.match("\\(Stage (\\d+\\.\\d+)\\)$")[1].split(".");
Expand Down Expand Up @@ -233,7 +233,7 @@ $(function (){
});

function setupExecutorEventAction() {
$(".item.box.executor").each(function () {
$(".vis-item.vis-box.executor").each(function () {
$(this).hover(
function() {
$($(this).find(".executor-event-content")[0]).tooltip("show");
Expand Down