[SPARK-17216][UI] fix event timeline bars length #14791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
changed the title
Member
|
Just checking here, how long was the task deserialization time in reality here, for example? looks like it's 8ms. If so then yes the "Before" is wrong. I want to make sure it's supposed to span the whole display in this case. |
Member
|
Jenkins test this please |
Author
|
One more screenshot with more values from the ui. Individual values sum up to the total of 43ms (displayed below in aggregated metrics). Also proportions indicate that the bars should have been wider |
|
Test build #64354 has finished for PR 14791 at commit
|
Member
|
Merged to master/2.0 |
asfgit
pushed a commit
that referenced
this pull request
Aug 27, 2016
## What changes were proposed in this pull request? Make event timeline bar expand to full length of the bar (which is total time) This issue occurs only on chrome, firefox looks fine. Haven't tested other browsers. ## How was this patch tested? Inspection in browsers Before  After  Author: Robert Kruszewski <[email protected]> Closes #14791 from robert3005/robertk/event-timeline. (cherry picked from commit 9fbced5) Signed-off-by: Sean Owen <[email protected]>
zzcclp
added a commit
to zzcclp/spark
that referenced
this pull request
Aug 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make event timeline bar expand to full length of the bar (which is total time)
This issue occurs only on chrome, firefox looks fine. Haven't tested other browsers.
How was this patch tested?
Inspection in browsers
Before
After
