Release 2.0 #263

Zabuzard · 2021-11-16T11:06:44Z

Overview

This marks the first release towards the Migrate existing commands objective, version 2.0.

It contains various commands, such as:

tag system
moderation commands
mod audit log
TeX command
voice chat activities

Plan

The plan is to release in a few days (Friday, 19. Nov. 2021), unless develop revealed any unstability in the recently merged features.

It is possible that the release gets delayed for a bit if any important features should be included short-term.

Checklist

Bumps JDA from 4.3.0_331 to 4.3.0_333. --- updated-dependencies: - dependency-name: net.dv8tion:JDA dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [jackson-dataformat-csv](https://github.com/FasterXML/jackson-dataformats-text) from 2.12.5 to 2.13.0. - [Release notes](https://github.com/FasterXML/jackson-dataformats-text/releases) - [Commits](FasterXML/jackson-dataformats-text@jackson-dataformats-text-2.12.5...jackson-dataformats-text-2.13.0) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.dataformat:jackson-dataformat-csv dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps com.diffplug.spotless from 5.15.2 to 5.16.0. --- updated-dependencies: - dependency-name: com.diffplug.spotless dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

* Add Logviewer project * Remove JPA and Hibernate, switch to Database-project * Apply suggestions from code review

Co-authored-by: I-Al-Istannen <[email protected]>

Bumps JDA from 4.3.0_333 to 4.3.0_334. --- updated-dependencies: - dependency-name: net.dv8tion:JDA dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

* Disable buttons after being used * Added ephemeral explanation message to users clicking the buttons if they are not the user who triggered the command originally

Bumps a-vaadin-helper from 1.7.1 to 1.7.2. --- updated-dependencies: - dependency-name: org.vaadin.artur:a-vaadin-helper dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

*.db *.db-shm *.db-wal

The main method previously initialized the logger before setting the system properties, leading to issues with the ForkJoinPool.

from: Available commands: [org.togetherjava.tjbot.commands.system.ReloadCommand@1ad777f, org.togetherjava.tjbot.commands.basic.PingCommand@5bbbdd4b, org.togetherjava.tjbot.commands.basic.DatabaseCommand@438bad7c] to: Available commands: [reload, ping, db]

When using a DB path that has no direct parents, for example a relative path in the same directory like `local-database.db` (as recommended by the tutorial), the old code crashed since `getParent()` returned `null`. This fixes it by: 1. using the absolute path before `getParent()` 2. checking the result of `getParent()` for `null`

- monthly - only major updates (no patch, no minor) - up to 10 at a time (default was 5)

… and org.togetherjava.logwatcher to org.togetherjava.tjbot.logwatcher to keep consistency

Co-authored-by: Zabuzard <[email protected]>

Co-authored-by: Heatmanofurioso <[email protected]>

* Add log severity highlighting to Logviewer #186

* introduced helper method `handleChecks` where all the preconditions are checked (reason, permissions, ...)

* this allows to give selected roles the ability to use moderation commands without giving them the ability to use them without the bot. * for example staff assistants could kick users with the bot, but not without the bot * that way, we can force them to go through the bot instead of using Discord GUI or other bots * which gives us more control and visibility

CLAassistant · 2021-11-16T11:06:57Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 10 committers have signed the CLA.

✅ Zabuzard
✅ krankkkk
✅ talentedasian
✅ illuminator3
✅ Tais993
✅ borgrel
✅ java-coding-prodigy
❌ RandomGHAcct
❌ I-Al-Istannen
❌ Yusuf Arfan Ismail

Yusuf Arfan Ismail seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

illuminator3 · 2021-11-16T11:29:52Z

Could we please wait for the bytecode command? I'm pretty sure a lot of members would want that command on the main server.

Zabuzard · 2021-11-16T11:32:27Z

Could we please wait for the bytecode command? I'm pretty sure a lot of members would want that command on the main server.

Have a rough ETA for that? That said, I also dont see any problem in having another release 1-2 weeks after.

java-coding-prodigy · 2021-11-17T12:19:08Z

Also, do wait for wolfram-alpha command, it is not very useful but it would suck if it got delayed by 6 months for this.
It will most likely get completed by next week anyway, so before bytecode command for sure.

Tais993 · 2021-11-17T12:27:53Z

I also dont see any problem in having another release 1-2 weeks after.

No-one ever said 6 months and that's way too long.

We shouldn't constantly delay releases, so we'll see whenever that the Wolfram alpha command gets added.

Otherwise, 1/2 weeks

java-coding-prodigy · 2021-11-17T12:36:23Z

We shouldn't constantly delay releases, so we'll see whenever that the Wolfram alpha command gets added.

Like I said, probably next week.

Zabuzard · 2021-11-17T13:24:54Z

We shouldn't constantly delay releases, so we'll see whenever that the Wolfram alpha command gets added.

Like I said, probably next week.

Dont forget that features also have to be released and tested successfully for about a week on the develop server at least.

I doubt your feature will make it into this release. I also doubt free will make it. But thats okay, we will just ship another release in 2 weeks or so...

java-coding-prodigy · 2021-11-17T16:51:08Z

So neither will bytecode make it I guess...

* void read -> readAndConsume * T write -> writeAndProvide

sonarqubecloud · 2021-11-18T18:55:59Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication

Zabuzard and others added 30 commits October 8, 2021 11:55

Error reporting if bot added with wrong scope

ecdc856

Bump JDA from 4.3.0_331 to 4.3.0_333

b4e971e

Bumps JDA from 4.3.0_331 to 4.3.0_333. --- updated-dependencies: - dependency-name: net.dv8tion:JDA dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Multithreading for command system

e71af63

Added Logviewer project

ebf44fb

* Add Logviewer project * Remove JPA and Hibernate, switch to Database-project * Apply suggestions from code review

Fixes HTTPS Redirects on the VPS

1945757

Co-authored-by: I-Al-Istannen <[email protected]>

Bump JDA from 4.3.0_333 to 4.3.0_334

e77c3fd

Bumps JDA from 4.3.0_333 to 4.3.0_334. --- updated-dependencies: - dependency-name: net.dv8tion:JDA dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Deactivate reload buttons after usage, reload message to other users

638f957

* Disable buttons after being used * Added ephemeral explanation message to users clicking the buttons if they are not the user who triggered the command originally

Added pic where bot says hello to readme

a833f88

Application does not create necessary Directories for the DB

f40caa0

Do not create the file as directory

d72da74

Gitignore Databases

8fc569e

*.db *.db-shm *.db-wal

Add a Boostrap launcher without dependencies to initialize the system

b149f77

The main method previously initialized the logger before setting the system properties, leading to issues with the ForkJoinPool.

Skip sonarcloud analysis if secrets are not available

2eb711a

Improve available commands log

f8331cc

from: Available commands: [org.togetherjava.tjbot.commands.system.ReloadCommand@1ad777f, org.togetherjava.tjbot.commands.basic.PingCommand@5bbbdd4b, org.togetherjava.tjbot.commands.basic.DatabaseCommand@438bad7c] to: Available commands: [reload, ping, db]

Less spammy dependabot updates

db153d5

- monthly - only major updates (no patch, no minor) - up to 10 at a time (default was 5)

gitignore generated vaadin files

14b73c4

Change org.togetherjava.formatter to org.togetherjava.tjbot.formatter…

82e5609

… and org.togetherjava.logwatcher to org.togetherjava.tjbot.logwatcher to keep consistency

Propogated onReady event from CommandSystem to SlashCommand

37e54e5

Adding a /tex command for LaTeX support, based on the lib jlatexmath

4bb7ee4

Fix #208, #206 (tex background color, tex error message UX)

32e46b4

Tag system (#135)

58afeb7

Co-authored-by: Zabuzard <[email protected]>

Added JDA mock and tests

672608c

Co-authored-by: Heatmanofurioso <[email protected]>

Fix Javadoc code example for commands (#199)

95d7f32

Add log severity highlighting to Logviewer #186 (#191)

ec2469d

* Add log severity highlighting to Logviewer #186

Update JDA application module

281dba5

staff-helper renamed to staff-assistants

a217bc4

Zabuzard added 12 commits November 16, 2021 09:35

Using embed instead of plain messages

f3c2738

using constants to separate magic strings

d2916ea

Readability cleanup on the "checks"

d17d766

* introduced helper method `handleChecks` where all the preconditions are checked (reason, permissions, ...)

NotNull for enum (CR by Tais)

ea3196a

Added back permission based system, additionally as secondary layer

235b984

Spotless after rebase

c04956b

empty line for readability (CR Tais)

a6ca390

Simplified ban/kick flow using individual methods (CR Tais)

4ea1de0

Moved failure handling for unban into method (CR Tais)

1ae5273

Missing imports after rebase

036b893

Some adjustments, shared the wrong CLA

f4593eb

Zabuzard added the release Marks official releases and talks about them, i.e. merges from develop to master label Nov 16, 2021

Zabuzard added this to the Migrate existing commands milestone Nov 16, 2021

Zabuzard self-assigned this Nov 16, 2021

Zabuzard requested a review from a team as a code owner November 16, 2021 11:06

Zabuzard added 2 commits November 17, 2021 09:07

Make Tag-Manage based on roles

d1fba01

using helper for role check (CR illu)

224d3fe

Zabuzard added 2 commits November 18, 2021 19:51

Renamed database methods

a96f447

* void read -> readAndConsume * T write -> writeAndProvide

Removed now obsolete curlies and java:S1602

2087bfd

Zabuzard merged commit 2087bfd into master Nov 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Release 2.0 #263

Release 2.0 #263

Uh oh!

Zabuzard commented Nov 16, 2021 •

edited

Loading

Uh oh!

CLAassistant commented Nov 16, 2021 •

edited

Loading

Uh oh!

illuminator3 commented Nov 16, 2021

Uh oh!

Zabuzard commented Nov 16, 2021 •

edited

Loading

Uh oh!

java-coding-prodigy commented Nov 17, 2021 •

edited

Loading

Uh oh!

Tais993 commented Nov 17, 2021

Uh oh!

java-coding-prodigy commented Nov 17, 2021

Uh oh!

Zabuzard commented Nov 17, 2021

Uh oh!

java-coding-prodigy commented Nov 17, 2021

Uh oh!

sonarqubecloud bot commented Nov 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Release 2.0 #263

Release 2.0 #263

Uh oh!

Conversation

Zabuzard commented Nov 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Plan

Checklist

Uh oh!

CLAassistant commented Nov 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

illuminator3 commented Nov 16, 2021

Uh oh!

Zabuzard commented Nov 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

java-coding-prodigy commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tais993 commented Nov 17, 2021

Uh oh!

java-coding-prodigy commented Nov 17, 2021

Uh oh!

Zabuzard commented Nov 17, 2021

Uh oh!

java-coding-prodigy commented Nov 17, 2021

Uh oh!

sonarqubecloud bot commented Nov 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Zabuzard commented Nov 16, 2021 •

edited

Loading

CLAassistant commented Nov 16, 2021 •

edited

Loading

Zabuzard commented Nov 16, 2021 •

edited

Loading

java-coding-prodigy commented Nov 17, 2021 •

edited

Loading