Migrate mute, unmute commands

[Zabuzard]

Overview

Partially implements #64 . Adds commands:

• /mute user reason
• /unmute user reason

The commands are fairly simple and follow the pattern introduced by #244 . That said, the branch is based on that branch and hence also blocked by its release.

---

Notes

This PR slightly changes the initialization process of the bot by moving routines and listeners down into Commands.java (instead of Application.java). This is a temporary change that is unfortuantely required, since they need access to systems such as TagSystem or ModAuditLogStore, and also the JDA instance (which is now also passed down through CommandSystem).

All of this will be made nicer anyways with #235 and #236 , so I wouldnt bother too much for now.

---

Bot permission change

The bot needs to listen to user-join events, which requires the privileged Server Members Intent to be enabled (already enabled it on our bots and added it to the config, since it doesnt harm - but we have to tell contributors in an announcement).

---

Checklist

Basic

• Mute a user
• Unmute a user

DM

• Mute a user who has disabled DMs
• Mute a user who has enabled DMs
• Unmute a user who has disabled DMs
• Unmute a user who has enabled DMs

Foreign users

• Attempt to mute a user who is not in the guild
• Attempt to unmute a user who is not in the guild

Logic

• Attempt to mute an already muted user
• Attempt to unmute an user who is not muted yet

Permissions

• Mute with the bot not having role permissions
• Unmute with the bot not having role permissions
• Mute with the author not having the soft moderation role
• Unmute with the author not having the soft moderation role
• Mute with the bot being lower in the hierarchy than the target
• Unmute with the bot being lower in the hierarchy than the target
• Mute with the bot being lower in the hierarchy than the muted role
• Unmute with the bot being lower in the hierarchy than the muted role
• Mute with the author being lower in the hierarchy than the target
• Unmute with the author being lower in the hierarchy than the target
• Mute with the author being lower in the hierarchy than the muted role
• Unmute with the author being lower in the hierarchy than the muted role

Rejoin

• Mute user, then leave and rejoin, user should be muted again
• Mute user, then unmute. Then leave and rejoin, user should not be muted
• Mute user, then leave. Unmute and rejoin, user should not be muted
• Mute user, then leave. Unmute and mute. Then rejoin, user should be muted again

---

TODO

• If user leaves and joins the server back, they would be unmuted again. The role has to be applied again by the bot (use database, listen to join event, ...)

[Zabuzard]

[Zabuzard]

SonarCloud Quality Gate failed.

0 Bugs 0 Vulnerabilities 0 Security Hotspots 2 Code Smells

0.0% Coverage 3.4% Duplication

The remaining code duplication is a non-issue and cant be fixed nicely. (it is complaining about the part where we extract the arguments out of the event call)

I am going to ignore this and push anyways.

[Zabuzard]

draft until unblocked

[CLAassistant]

All committers have signed the CLA.

Implemented.

[Zabuzard]

If the user rejoins the server they're unmuted.

Seems to work now.

done

[Zabuzard]

Resolved conflicts, no code changes. Tais approval is still valid.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

0.0% Coverage
6.7% Duplication