Skip to content

Add log severity highlighting to Logviewer #186 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 23, 2021
Merged

Add log severity highlighting to Logviewer #186 #191

merged 10 commits into from
Oct 23, 2021

Conversation

krankkkk
Copy link
Contributor

Add's the requested css Classes to the Views based on the loglevels, with some basic filtering functionality.

File-View:
File-View

Streamed-View:
Streamed-View

@krankkkk krankkkk requested review from a team as code owners October 15, 2021 22:58
Zabuzard
Zabuzard previously approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share a screenshot of the "basic filtering" functionality?

@Zabuzard Zabuzard added the enhancement New feature or request label Oct 16, 2021
@illuminator3 @krankkkk
Change org.togetherjava.formatter to org.togetherjava.tjbot.formatter…
2baea4a 
… and org.togetherjava.logwatcher to org.togetherjava.tjbot.logwatcher to keep consistency
@krankkkk
Copy link
Contributor Author

Can you share a screenshot of the "basic filtering" functionality?

File-View:
File

Streamed-View:
Streamed

Zabuzard
Zabuzard previously approved these changes Oct 16, 2021
View reviewed changes
I-Al-Istannen
I-Al-Istannen previously requested changes Oct 17, 2021
View reviewed changes
@Zabuzard
Copy link
Member

@krankkkk Do you think you solved everything Istannen requested? If he doesnt respond and you think that you addressed everything, we can also just merge without him.

@krankkkk
Copy link
Contributor Author

krankkkk commented Oct 23, 2021 •
edited
Loading

@krankkkk Do you think you solved everything Istannen requested? If he doesnt respond and you think that you addressed everything, we can also just merge without him.

Except the parts with final where we have a difference of opinion, i changed to what he requested

@Zabuzard
Copy link
Member

@krankkkk Do you think you solved everything Istannen requested? If he doesnt respond and you think that you addressed everything, we can also just merge without him.

Except the parts with final where we have a difference of opinion, i changed to what he requested

Okay. Thats an opinion based topic anyways and, after all, he said NIT. I guess we can merge then.

@Zabuzard Zabuzard dismissed I-Al-Istannen’s stale review October 23, 2021 15:09

Changes have been implemented

@Zabuzard
Copy link
Member

Feel free to hit the button now, or cleanup ur history first or whatever.

@krankkkk krankkkk merged commit ec2469d into Together-Java:develop Oct 23, 2021
@krankkkk krankkkk deleted the feature/Highlighting branch October 23, 2021 15:49
@illuminator3 illuminator3 linked an issue Oct 31, 2021 that may be closed by this pull request
Add log severity highlighting to Logviewer #186
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Tais993 Tais993 Tais993 approved these changes

@marko-radosavljevic marko-radosavljevic Awaiting requested review from marko-radosavljevic

@I-Al-Istannen I-Al-Istannen Awaiting requested review from I-Al-Istannen

Assignees

@krankkkk krankkkk

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add log severity highlighting to Logviewer

6 participants

@krankkkk @Zabuzard @I-Al-Istannen @marko-radosavljevic @Tais993 @illuminator3