Make Tag-Manage based on roles #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zabuzard
added
the
enhance command
Zabuzard
requested review from
Heatmanofurioso,
I-Al-Istannen,
Tais993,
illuminator3,
java-coding-prodigy and
marko-radosavljevic
Zabuzard
force-pushed
the
feature/tag_manage_use_roles
branch
from
0f844da to
dd642ab
Compare
marko-radosavljevic
previously approved these changes
Nov 9, 2021
illuminator3
previously requested changes
Nov 14, 2021
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagManageCommand.java
Outdated
Show resolved
Hide resolved
Zabuzard
force-pushed
the
feature/tag_manage_use_roles
branch
from
43dd20e to
6eff89d
Compare
marko-radosavljevic
previously approved these changes
Nov 15, 2021
Zabuzard
force-pushed
the
feature/tag_manage_use_roles
branch
from
6eff89d to
edf5687
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Merging. Last unreviews code change is 7 days ago. Got approved by marko and illu (before the force pushes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements and closes #253 .
This will make the
/tag-managecommand based on roles instead of theMESSAGE_MANAGEpermission.That way we have more granular control over who can use it and, in particular, grant it as a perk to roles such as Top Helpers or others (without giving them the extended permissions on Discord itself, such as message deletion).
Config changes
This changes the config and adds a new entry to it: