Skip to content

Conversation

@SyntaxKay
Copy link
Owner

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

daniel-mindmagnet and others added 30 commits October 14, 2018 18:29
Get rid of unnecessary reviews queries on product listing:
"select review_entity_summary.* from review_entity_summary where (review_entity_summary.entity_pk_value = ?) and (store_id = ?)" 
This query was executed for each product on listing which didn't have a review summary(@see: Magento\Review\Block\Product\ReviewRenderer::getReviewsSummaryHtml)
code clean up
Stanislav Idolov and others added 29 commits November 22, 2018 13:51
 - Merge Pull Request magento/graphql-ce#221 from ronak2ram/graphql-ce:Fixed-218
 - Merged commits:
   1. bf0030f
   2. 4eac0fc
   3. 60f91ee
   4. 5c6f20f
   5. 922d398
   6. 6d984eb
   7. d3a22e9
   8. 772d4da
 - Merge Pull Request magento/graphql-ce#262 from VoronoyAlexandr/graphql-ce:260_schema_must_contain_unique_named_types_but_contains_multiple_types_named
 - Merged commits:
   1. bf346d1
   2. 6e32307
Accepted Public Pull Requests:
 - #19326: fix: remove old code in tabs, always set tabindex to 0 when tabs are � (by @DanielRuf)
 - #19309: Removed $this->setShowGlobalIcon(); (by @sreichel)
 - #19299: Fix styling issue for order items table (by @dmytro-ch)
 - #18609: Binding to event collapsible scroll (by @danielgheoltan)
 - #19277: Remove cart edit link extra space (by @VincentMarmiesse)
 - #18888: Fixed rating issue website wise (by @saphaljha)
 - #19213: Fix dependency between Elasticsearch configuration fields (by @ajardin)
 - #19195: [Newsletter] Fixing the customer subscribing from different stores (by @eduard13)
 - #19183: [Captcha] Integration tests for wrong captcha (by @eduard13)
 - #19180: [Forwardport] Fix/add expresion (by @torhoehn)
 - magento-engcom/import-export-improvements#152: Removed method annotation without argument from PHPDoc (by @VoronoyAlexandr)
 - #19024: Add-validation-new-from-date-less-than-new-to-date-in-SCV-product-import (by @agorbulin)
 - #19053: Magento backend  Notifications counter round icon small cut from right side (by @abrarpathan19)
 - #19039: #13157 - Last Ordered Items block - bad js code (by @omiroshnichenko)
 - #18703: Changed get product way in blocks with related products (by @henryktews)
 - magento-engcom/import-export-improvements#148: Clean Up Magento/ImportExport/Controller/Adminhtml/History/Download (by @denispapec)
 - #18641: Set cache id prefix on installation (by @schmengler)


Fixed GitHub Issues:
 - #18192: Backend issue : "ratings isn't  available" website wise (reported by @hardik-krish) has been fixed in #18888 by @saphaljha in 2.3-develop branch
   Related commits:
     1. 1c820be
     2. 8ea303b
     3. cd24396
     4. cbbaf12
     5. 611969d
     6. 774164c
     7. 2ea37a8
     8. 0e59e8c
     9. b9790c6

 - #19172: Newsletter subscription does not set the correct store_id if already subscribed.  Not Fixed in 2.3-dev (reported by @bbmxxc) has been fixed in #19195 by @eduard13 in 2.3-develop branch
   Related commits:
     1. c9b5250
     2. 3b84172

 - #17635: addExpressionFieldToSelect has to be called after all addFieldToSelect (reported by @dbsdsun) has been fixed in #19180 by @torhoehn in 2.3-develop branch
   Related commits:
     1. e697698
     2. 3050d23
     3. 99ea195

 - #18887: Magento backend  Notifications counter round icon small cut from right side (reported by @abrarpathan19) has been fixed in #19053 by @abrarpathan19 in 2.3-develop branch
   Related commits:
     1. 4a945f2
     2. 9e9c74c

 - #13157: Last Ordered Items block - bad js code  (reported by @Eytham) has been fixed in #19039 by @omiroshnichenko in 2.3-develop branch
   Related commits:
     1. c333367
     2. 4803537
     3. 7c9de8e
     4. eaaed4b

 - #15828: Multisite installation, default website slow (X-Magento-Vary) (reported by @Flowlance) has been fixed in #18641 by @schmengler in 2.3-develop branch
   Related commits:
     1. 12b7e08
     2. 6a68a18
     3. 3ccd55e
     4. f14949c
 - merged latest code from mainline branch
[EngCom] Public Pull Requests - GraphQL
@SyntaxKay SyntaxKay merged commit c429462 into SyntaxKay:2.3-develop Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.