Skip to content

Conversation

@dmytro-ch
Copy link
Contributor

Fix the issue with repetitive "tbody" tag for order items table.

Description (*)

There is an issue with repetitive "tbody" tag for order items table. As result, the incorrect styles are applied for the table.
The "striped table" styles, defined in app/design/frontend/Magento/luma/Magento_Customer/web/css/source/_module.less:179, expected to be used for Luma theme.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Check the order/return items tables for both guest and customer.

Expected result

  1. There is no repetitive "tbody" for order items table.
  2. As result, the "striped table" styles should be applied.

screen shot 2018-11-21 at 1 51 28 pm

This is the expected view of the table, defined in app/design/frontend/Magento/luma/Magento_Customer/web/css/source/_module.less:179.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar November 21, 2018 12:52
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend Area: Frontend Component: Sales labels Nov 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Nov 21, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: https://i-19299-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Contributor

rogyar commented Nov 21, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-19299.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants