Newsletter subscription does not set the correct store_id if already subscribed. Not Fixed in 2.3-dev

[bbmxxc]

Regarding #19131.
I (again) tried it on 2.3-dev an the issue is not fixed in 2.3-dev.

Preconditions (*)

1. latest Magento Version 2.3-dev
2. Have at least two stores ( A and B)

Steps to reproduce (*)

1. Register a user in A
2. Subscribe to Newsletter in A
3. Switch to Store B
4. Subscribe to Newsletter again

Expected result (*)

1. When in store B, Subscriber::loadByEmail() should work
   2. SELECT store_id, customer_id FROM newsletter_subscriber should look like this:

+----------+-------------+
| store_id | customer_id |
+----------+-------------+
|        1 |           1 |
|        2 |           1 |

Actual result (*)

1. When in store B, loadByEmail() (or loadById() ) cant find the subscriber since
2. SELECT store_id, customer_id FROM newsletter_subscriber looks like this:

+----------+-------------+
| store_id | customer_id |
+----------+-------------+
|        1 |           1 |
|        1 |           1 |

What i think where the error is

In app/code/Magento/Newsletter/Model/Subscriber.php starting on line 468:
If the subscriber already exists with this email, the new entry gets the $customer->getStoreId()
not the $this->_storeManager->getStore()->getId()

If this is the intended behavior then loadByEmail() or loadByCustomerId() should be store_id agnostic.

Cheers!
Ben

[magento-engcom-team]

Hi @bbmxxc. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@bbmxxc do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

Hi @bbmxxc on fresh magento 2.3-dev instance

[bbmxxc]

Hi! Thanks for the fast reply. But this are all different users. Try registering an user in one store and subscribing to the newsletter in a different one.

@bbmxxc but if i switch to store B then user logout.

[bbmxxc]

Well my customer stays logged in. But you could still log him in again at the other store.

[bbmxxc]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @bbmxxc. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @bbmxxc, here is your Magento instance.
Admin access: http://34.228.235.121/i-19172-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[bbmxxc]

I rebuild the situation on requested instance. There is StoreA and StoreB and a user registered on StoreA. I have subscribed to the newsletter on both stores but the store_id saved to the subscription is always that of StoreA.

[magento-engcom-team]

Hi @eduard13. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[eduard13]

Hi @bbmxxc I'm not sure how could you get the following result:

+----------+-------------+
| store_id | customer_id |
+----------+-------------+
|        1 |           1 |
|        1 |           1 |

As there is no way to subscribe the customer, because he's already subscribed in another store. Can you give me more details regarding this?
I followed the same steps, but couldn't get the duplication rows in DB (tried in 2.2 and 2.3).

I agree that there is an issue regarding the customer subscription from different stores and I'm going to investigate this.
The steps to reproduce:

1. Create 2 stores: A(default) and B
2. Login on the frontend
3. Subscribe to Newsletter (which should be successfully)
4. Switch to store B
5. Subscribe to Newsletter (you get the success message, but the subscription wasn't saved)

Thank you.