Fix dependency between Elasticsearch configuration fields

[ajardin]

Description (*)

There is a small typo in the Elasticsearch adminhtml configuration that causes the persistent hiding of the Elasticsearch HTTP Username and Elasticsearch HTTP Password fields when Elasticsearch 5.0+ is used as search engine even with the HTTP authentication activated.

Manual testing scenarios (*)

1. Log in to the back office.
2. Go to Stores > Configuration > Catalog > Catalog > Catalog Search.
3. Select the Elasticsearch 5.0+ value in Search Engine.
4. Select the Yes value in Enable Elasticsearch HTTP Auth.
5. Both Elasticsearch HTTP Username and Elasticsearch HTTP Password fields are still hidden.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @ajardin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[ajardin]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @ajardin. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @ajardin, here is your new Magento instance.
Admin access: http://34.228.235.121/pr-19213//admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3465 has been created to process this Pull Request

[magento-engcom-team]

@ajardin thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @ajardin. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.