-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Feat] Add DataLoader state dict to Loop state dict - 5/n #8370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kaushik B <[email protected]>
Co-authored-by: tchaton <[email protected]>
* add mdformat * exclude chlog * fix *** Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Carlos Mocholí <[email protected]>
…summary.summarize() (#8513) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: ananthsub <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: ananthsub <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>
An error occurred while trying to automatically change base from
data_loading_extensions
to
master
August 5, 2021 13:04
An error occurred while trying to automatically change base from
data_loading_extensions
to
master
August 5, 2021 13:04
An error occurred while trying to automatically change base from
data_loading_extensions
to
master
August 5, 2021 13:04
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## data_loading_extensions #8370 +/- ##
=========================================================
+ Coverage 45% 93% +48%
=========================================================
Files 217 169 -48
Lines 14237 14073 -164
=========================================================
+ Hits 6373 13042 +6669
+ Misses 7864 1031 -6833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the dataloader states to loop state_dict only if fault_tolerant is enabled.
To be merged after #8334 (1/2), #8362 (2/2), #8364 (1/2) #8366 (2/2).
Does your PR introduce any breaking changes ? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃