Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 11, 2021

What does this PR do?

This PR adds the dataloader states to loop state_dict only if fault_tolerant is enabled.

To be merged after #8334 (1/2), #8362 (2/2), #8364 (1/2) #8366 (2/2).

Screenshot 2021-07-11 at 12 24 55

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Jul 11, 2021
@tchaton tchaton added this to the v1.4 milestone Jul 11, 2021
@tchaton tchaton added the design Includes a design discussion label Jul 11, 2021
kaushikb11 and others added 19 commits August 2, 2021 21:24
* Fix ddp accelerator choice for cpu
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kaushik B <[email protected]>
* add mdformat
* exclude chlog
* fix ***

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
…summary.summarize() (#8513)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
An error occurred while trying to automatically change base from data_loading_extensions to master August 5, 2021 13:04
An error occurred while trying to automatically change base from data_loading_extensions to master August 5, 2021 13:04
An error occurred while trying to automatically change base from data_loading_extensions to master August 5, 2021 13:04
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #8370 (299e289) into data_loading_extensions (087df3d) will increase coverage by 48%.
The diff coverage is 95%.

❗ Current head 299e289 differs from pull request most recent head 8695df0. Consider uploading reports for the commit 8695df0 to get more accurate results

@@                    Coverage Diff                    @@
##           data_loading_extensions   #8370     +/-   ##
=========================================================
+ Coverage                       45%     93%    +48%     
=========================================================
  Files                          217     169     -48     
  Lines                        14237   14073    -164     
=========================================================
+ Hits                          6373   13042   +6669     
+ Misses                        7864    1031   -6833     

@awaelchli awaelchli closed this Aug 5, 2021
@awaelchli awaelchli deleted the loop_state_dict branch August 27, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Includes a design discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.