Skip to content

Conversation

@calebrob6
Copy link
Contributor

What does this PR do?

Fix an import deprecation warning (collections -> collections.abc). Similar to #3110.

The warning this addresses is:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
  from collections import Callable

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #8687 (4f86dd2) into master (e5d9e21) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8687    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         167     167            
  Lines       14033   14036     +3     
=======================================
- Hits        13004   12452   -552     
- Misses       1029    1584   +555     

@calebrob6
Copy link
Contributor Author

(of note: I just searched and this is the only place in the codebase where this class of warnings is happening)

@mergify mergify bot added the ready PRs ready to be merged label Aug 3, 2021
@carmocca carmocca added this to the v1.4.x milestone Aug 3, 2021
@carmocca carmocca added the bug Something isn't working label Aug 3, 2021
@carmocca carmocca enabled auto-merge (squash) August 3, 2021 12:56
@carmocca carmocca merged commit 9ca02f5 into Lightning-AI:master Aug 3, 2021
@adamjstewart
Copy link
Contributor

Was literally just about to submit a PR to fix this, thanks @calebrob6!

SeanNaren pushed a commit that referenced this pull request Aug 10, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit 9ca02f5)
lexierule pushed a commit that referenced this pull request Aug 11, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit 9ca02f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants