Skip to content

Conversation

@stancld
Copy link
Contributor

@stancld stancld commented Jun 29, 2021

What does this PR do?

Part of #7037. This PR disentangles large #7218. It fixes mypy typing in utilities.device_parser.py.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #8201 (876703a) into master (963c267) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8201    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14072   14071     -1     
=======================================
- Hits        13043   12464   -579     
- Misses       1029    1607   +578     

@Borda Borda marked this pull request as draft June 29, 2021 18:18
@stale
Copy link

stale bot commented Jul 14, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jul 14, 2021
@awaelchli awaelchli removed the won't fix This will not be worked on label Jul 14, 2021
@awaelchli awaelchli added this to the v1.5 milestone Jul 14, 2021
@stancld stancld changed the title [WIP] Fix mypy in utilities.distributed Fix mypy in utilities.distributed Aug 2, 2021
@stancld stancld changed the title Fix mypy in utilities.distributed [WIP] Fix mypy in utilities.distributed Aug 2, 2021
@stancld stancld changed the title [WIP] Fix mypy in utilities.distributed Fix mypy in utilities.distributed Aug 4, 2021
@stancld stancld marked this pull request as ready for review August 4, 2021 16:35
@mergify mergify bot added the ready PRs ready to be merged label Aug 4, 2021
@awaelchli awaelchli enabled auto-merge (squash) August 5, 2021 09:24
@awaelchli awaelchli merged commit aacd131 into Lightning-AI:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants