Skip to content

Conversation

@stancld
Copy link
Contributor

@stancld stancld commented Aug 2, 2021

What does this PR do?

Part of #7037. This PR disentangles large #7218. It fixes mypy typing in utilities.device_parser.py.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@stancld stancld changed the title [WIP] Fix mypy typing for utilities.debugging [WIP] Fix mypy typing for utilities.debugging Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #8672 (d1923c4) into master (9ca02f5) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8672   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         168     168           
  Lines       14044   14048    +4     
======================================
+ Hits        12461   12465    +4     
  Misses       1583    1583           

@Borda Borda marked this pull request as draft August 2, 2021 06:43
@Borda Borda added the refactor label Aug 2, 2021
@carmocca
Copy link
Contributor

carmocca commented Aug 2, 2021

There's one mypy error

pytorch_lightning/utilities/debugging.py:173: error: Item "None" of "Optional[ModelCheckpoint]" has no attribute "monitor" [union-attr]

@carmocca carmocca added the ci Continuous Integration label Aug 2, 2021
@carmocca carmocca added this to the v1.5 milestone Aug 2, 2021
@stancld
Copy link
Contributor Author

stancld commented Aug 2, 2021

@carmocca

There's one mypy error

pytorch_lightning/utilities/debugging.py:173: error: Item "None" of "Optional[ModelCheckpoint]" has no attribute "monitor" [union-attr]

The return type of trainer.checkpoint_callback is defined as Optional[ModelCheckpoint] from

/pytorch_lightning/trainer/properties.py:383:    def checkpoint_callback(self) -> Optional[ModelCheckpoint]:

Can we here always assume checkpoint_callback is not None?

@carmocca
Copy link
Contributor

carmocca commented Aug 2, 2021

Can we here always assume checkpoint_callback is not None?

No, users can disable it by setting Trainer(checkpoint_callback=False)

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@stancld stancld changed the title [WIP] Fix mypy typing for utilities.debugging Fix mypy typing for utilities.debugging Aug 4, 2021
@stancld stancld marked this pull request as ready for review August 4, 2021 07:10
@mergify mergify bot added the ready PRs ready to be merged label Aug 4, 2021
@awaelchli awaelchli enabled auto-merge (squash) August 5, 2021 11:45
@awaelchli awaelchli merged commit 69cd927 into Lightning-AI:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants