-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix mypy typing for utilities.debugging
#8672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy typing for utilities.debugging
#8672
Conversation
utilities.debugging
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #8672 +/- ##
======================================
Coverage 89% 89%
======================================
Files 168 168
Lines 14044 14048 +4
======================================
+ Hits 12461 12465 +4
Misses 1583 1583 |
|
There's one mypy error
|
The return type of Can we here always assume |
No, users can disable it by setting |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
utilities.debuggingutilities.debugging
What does this PR do?
Part of #7037. This PR disentangles large #7218. It fixes mypy typing in
utilities.device_parser.py.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃