Skip to content

Conversation

@knirirr
Copy link
Contributor

@knirirr knirirr commented Jul 25, 2022

There's an existing component which shows a record's type/registry overlaid with a status icon, and it already contains a switch to display only the status. I have used this in the position requested for records in the left column as there's already a type/registry icon to the left. I tried fitting the status icon on the left, but had some difficulty.
Status only appears on the left column (i.e. records not-yet-added to relations) as the data which are used for the right-hand column don't include any status information.
It wasn't clear to me from the ticket if the icons were being requested for both columns; if not then this PR can be reviewed as it stands. But, if they are required, I'll have to open another ticket for changes to the server so that it can supply record status in the relevant part of the data.

@knirirr knirirr linked an issue Jul 25, 2022 that may be closed by this pull request
@knirirr knirirr marked this pull request as ready for review July 25, 2022 15:21
Copy link
Contributor

@ramGranell ramGranell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work correctly this new record status in the edit symbol system. My only comment is that when your mouse is over this new status symbol it says "Ready", "Uncertain" that is very useful. However, when I put the mouse over the symbols next to it (the eye and arrow) I was expecting to find an information sign saying "View" and "Add" in the same style as it happened with the status icon. That's only a comment that is not related with the original ticket.

Copy link
Contributor

@allysonlister allysonlister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great. You both also raise valid points. Addressing these:

  1. I think we should have a separate ticket to add hover-over text for the preview and add, as Ramon suggests
  2. You're right @knirirr I wasn't clear in this ticket if the status should be on both tabs. Let's complete this one as-is, but then please could you create another ticket to add the same information on the right-hand side.

Thanks!
Allyson

@knirirr knirirr merged commit e9e79b5 into dev Jul 26, 2022
@knirirr knirirr deleted the status_in_editing_1763 branch July 26, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display record status within relationship tab when editing records

5 participants