Develop - BETA #345
Merged
Develop - BETA #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup Block Diagonal Tests
Add Volume Class Unit Tests
Remove quaternions
Remove legacy aspire/aspire code
remove deprecated dependency
Tee DEBUG to file, INFO to console
implement __str__ for Xform classes and improve Multiply and Shift Xforms
Separate normalization factor of FB basis into radial and angular parts
Add CLICK command for preprocess steps
these are unrelated to this PR changeset
these are unrelated to this PR changeset
latest flake8-bugbear fails on bare exceptions
Update finufft package/interface
Conflicts: src/aspire/basis/ffb_2d.py src/aspire/basis/fpswf_2d.py src/aspire/image/__init__.py src/aspire/noise/noise.py src/aspire/volume/__init__.py tests/test_fft.py
probably regression from merges
tighted up polar2d unit test
Contributor
|
Hi Garrett,
I agree with your comment. That’s a sensible plan moving forward.
Best,
Amit
From: Garrett Wright <[email protected]>
Sent: Monday, November 30, 2020 11:39 AM
To: ComputationalCryoEM/ASPIRE-Python <[email protected]>
Cc: Amit Singer <[email protected]>; Review requested <[email protected]>
Subject: Re: [ComputationalCryoEM/ASPIRE-Python] Develop - BETA (#345)
@garrettwrong <https://github.com/garrettwrong> requested your review on: #345 <#345> Develop - BETA.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#345 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGPAHMB3SVM32AU7DDXQ6TSSPDCBANCNFSM4UHZ5BHA> . <https://github.com/notifications/beacon/ABGPAHPV2HG55STSDOIHJHLSSPDCBA5CNFSM4UHZ5BHKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGO6GJCCNQ.gif>
|
ship config with nworkers=1 to prevent oversub
fix small import bug
includ centered fft functions in facade modules and replace FFT functions in other submodules
…n into update_readme
Update readme
janden
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should loosely be in a beta mode now.
That is, closing out any outstanding PRs (there are several) and limit ourselves to hot bug fixes in the content of this changeset proposed. I don't think any new features can be in scope at this point for EOY (which is tomorrow for planning purposes). We can prioritize certain items (CLI or class averaging for example) for another release. Nothing to my knowledge is worse off now than in
master, which would be a reasonable concern to stop the train. Because we are not feature complete software yet, this is essentially just an internal milestone release.Develop code already is versioned at 0.6.0. Whatever makes it into master with that version label is going to get a fixed tag in git (0.6.0). Then I can create and push the distribution to testing pypi and give that a spin before pushing to the official PyPI (now at 0.5.28).
From here we should move develop and minor releases more often. I expect less sweeping changes from now on.