Skip to content

tighted up polar2d unit test #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2020
Merged

tighted up polar2d unit test #334

merged 4 commits into from
Nov 25, 2020

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Nov 13, 2020

Closes #331

Casts to real, fixes rng seed used in randn, adds debug level logging and note for future devs.

@garrettwrong garrettwrong added bug Something isn't working CI Continuous Integration cleanup labels Nov 13, 2020
@garrettwrong garrettwrong requested a review from janden as a code owner November 13, 2020 20:40
@garrettwrong garrettwrong self-assigned this Nov 13, 2020
janden
janden previously approved these changes Nov 24, 2020
View reviewed changes
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Nov 24, 2020 •
edited
Loading

Minor conflict (single line module rename). Once passed CI will force merge, no substantive changes to require a re-review. (nm, was reviewed already)

@garrettwrong garrettwrong merged commit 00fe92a into develop Nov 25, 2020
@garrettwrong garrettwrong deleted the polar_2d_utest branch December 17, 2020 20:39
@garrettwrong garrettwrong mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden janden approved these changes

Assignees

@garrettwrong garrettwrong

Labels

bug Something isn't working CI Continuous Integration cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @janden