-
Notifications
You must be signed in to change notification settings - Fork 26
Remove legacy aspire/aspire code #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
janden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove code that depends on aspire.aspire. From what I understand, this should be restricted to aspire.commands.aspire, but there may be others.
|
Gotcha, yeah, I must have missed it because there were no tests... Will do. |
|
Updated. Besides a historical comment (im_translate2) grep for We will be able to bring back something similar or refresh this code, but I'm hoping we can keep it more consistent and constantly/automatically tested this time its integrated so it doesn't diverge as much... |
|
Sorry I was unclear. It's only the |
ac563ca to
a9c21cf
Compare
|
Okay, sure, I'll need to put the quickstart back then. I should have it ready in a few. Thanks |
a9c21cf to
63b5d0c
Compare
63b5d0c to
2b5b748
Compare
|
Restored the quickstart docs, rebased. Sorry for the noise. |
Created tag legacy_aspire to mark a commit before removal. Using that commit it should be possible to create a branch later, or otherwise recover the code in the state it was in today.
Removes the
src/aspire/aspiredirectory, and related doc page.Also includes a minor typo fix in
conf.pyI found when manually rebuilding the docs.