Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Oct 2, 2020

Created tag legacy_aspire to mark a commit before removal. Using that commit it should be possible to create a branch later, or otherwise recover the code in the state it was in today.

Removes the src/aspire/aspire directory, and related doc page.

Also includes a minor typo fix in conf.py I found when manually rebuilding the docs.

@garrettwrong garrettwrong requested a review from janden as a code owner October 2, 2020 17:07
@garrettwrong garrettwrong self-assigned this Oct 2, 2020
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove code that depends on aspire.aspire. From what I understand, this should be restricted to aspire.commands.aspire, but there may be others.

@garrettwrong
Copy link
Collaborator Author

Gotcha, yeah, I must have missed it because there were no tests... Will do.

@garrettwrong
Copy link
Collaborator Author

Updated. Besides a historical comment (im_translate2) grep for aspire.aspire is clean now. I should have checked the first time.

We will be able to bring back something similar or refresh this code, but I'm hoping we can keep it more consistent and constantly/automatically tested this time its integrated so it doesn't diverge as much...

@janden
Copy link
Collaborator

janden commented Oct 6, 2020

Sorry I was unclear. It's only the aspire.py file that needs to be removed. From what I understand, the others (apple.py, denoise.py, etc.) still work. We will probably want to rework the interface at some point, but they're not broken, so let's keep them.

@garrettwrong
Copy link
Collaborator Author

Okay, sure, I'll need to put the quickstart back then. I should have it ready in a few. Thanks

@garrettwrong
Copy link
Collaborator Author

Restored the quickstart docs, rebased. Sorry for the noise.

@garrettwrong garrettwrong requested a review from janden October 6, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants