Remove quaternions #245
Merged
Remove quaternions #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junchaoxia
requested review from
vineetbansal
and removed request for
janden
Collaborator
|
Didn't we decide to postpone this? |
Contributor
|
This may be my fault in suggesting to Junchao to work on this .. I was under the impression that this only involved removal of code/files, no edits. We'll table this for later. |
junchaoxia
force-pushed
the
rm_quaternions
branch
from
17fbe38 to
3927afe
Compare
Conflicts: tests/test_coor_trans.py
janden
requested changes
Oct 1, 2020
janden
approved these changes
Oct 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the issue #194 to remove functions, examples, and unit tests related to quaternions for generating random orientation angles.