twister: runner: add extra_args supporting platform and soc and simulation #79263
Conversation
zephyrbot
requested review from
KamilxPaszkiet,
LukaszMrugala,
PerMac,
aaronemassey,
asemjonovs,
gchwier,
golowanow,
jeremybettis,
nashif and
yperess
hakehuang
force-pushed
the
twister_extra_args
branch
from
8429367 to
ddfdbae
Compare
hakehuang
changed the title
hakehuang
force-pushed
the
twister_extra_args
branch
from
ddfdbae to
f790d18
Compare
|
@aaronemassey , @asemjonovs , @gchwier , @golowanow , @nashif , @PerMac please help to review |
golowanow
left a comment
golowanow
left a comment
There was a problem hiding this comment.
Commit message for extra_args addition needs adjustment to reflect actual changes: supporting arch, platform, and sumulation.
hakehuang
force-pushed
the
twister_extra_args
branch
from
f790d18 to
c08e1d2
Compare
|
@LukaszMrugala seems there is a bug in black box test see below '{"gcovr/format_version": "0.10", "files": []}' = <function dumps at 0x7f357f36aca0>({'files': [], 'gcovr/format_version': '0.10'}) the compare fails due to the hash sequence is not match but the content is the same |
@hakehuang - the fix should be in #79578 |
hakehuang
force-pushed
the
twister_extra_args
branch
from
c08e1d2 to
6ce6053
Compare
hakehuang
force-pushed
the
twister_extra_args
branch
from
6ce6053 to
1f9050c
Compare
There was a problem hiding this comment.
maybe could be worth to raise ConfigurationError, or at least log an error message, if len(cond_args) > 1, to avoid passing wrong extra_args to cmake.
There was a problem hiding this comment.
good suggestion. I add a warning when keys words are there but len is not enough.
hakehuang
force-pushed
the
twister_extra_args
branch
4 times, most recently
from
37ffe14 to
455a880
Compare
like extra_confs, add extr_args filterable by soc:<arch>:<extra_args> or platfrom:<platform name>: <extra_args> simulation:<simulator name>: <extra_args> which will only apply to given platform or arch Signed-off-by: Hake Huang <[email protected]>
now extra_args can support domain settings, add in doc. Signed-off-by: Hake Huang <[email protected]>
add test for platform in extra_args Signed-off-by: Hake Huang <[email protected]>
hakehuang
force-pushed
the
twister_extra_args
branch
from
455a880 to
7b09f6c
Compare
This is added via PRs zephyrproject-rtos#79337 and zephyrproject-rtos#79263 to automatically check if a colorbar pattern generated by a camera pipeline is correct or not. Signed-off-by: Phi Bang Nguyen <[email protected]>
This is added via PRs #79337 and #79263 to automatically check if a colorbar pattern generated by a camera pipeline is correct or not. Signed-off-by: Phi Bang Nguyen <[email protected]>
7 participants
twister: runner: add extra_args supporting platform and soc
like extra_confs, add extr_args filterable by
soc::<extra_args> or
platfrom:: <extra_args>
which will only apply to given platform or arch