samples: display: make display samples testable by twister #78988
Conversation
zephyrbot
requested review from
KamilxPaszkiet,
LukaszMrugala,
PerMac,
danieldegrasse,
gchwier,
golowanow,
jfischer-no,
kartben and
nashif
hakehuang
force-pushed
the
nxp_display
branch
from
67efce9 to
49732eb
Compare
danieldegrasse
left a comment
danieldegrasse
left a comment
There was a problem hiding this comment.
Display changes look ok, @anas could you review the twister addition?
There was a problem hiding this comment.
We should add some documentation on this new filter feature for twister, it seems like a useful addition
There was a problem hiding this comment.
yes, I need add document. done
zephyrbot
requested review from
aaronemassey,
asemjonovs,
jeremybettis and
yperess
|
from a quick glance it looks like something that could simplify our yamls. It could also help with the issue we discussed today with @nashif during testing meetings, i.e. having dozens of configuration variants for a test/sample and all of them getting separate builds. @hakehuang I think this PR can (should?) be split or reworked. As I understand, the majority of changes to the display samples has nothing to do with the namespaceing in extra_args. namespacing is only mentioned in docs and used in demo sample. Maybe namespacing could be used also in display sample in this PR? It looks like there are several very similar variants, where the only difference is platform_allow with a single platform and which shield should be used. Would it make sens to combine those into sth like: |
@PerMac I have split this PR in several commits. do you mean to split in to different PR, but the demo sample has a dependency on the runner changes.
the problem here is the shield and board are not 1to1 mapping, it is one to many. as you can see in display sample, mimxrt595_evk support twi display shield, and above logic can't resolve the conflicts. in display test, there is a filter called 'zephyr,display', which is obtained by shield board, so platform_allow is not needed, if the shield extra_args is not there. |
I don't want to slow this PR, but I think that the twister feature should probably be in a separate PR. I don't want people who would otherwise review this feature to miss its addition because it is present within a PR targeting display tests |
I add a PR(#79263) and will update this one once merged |
hakehuang
force-pushed
the
nxp_display
branch
from
89abe8e to
450fb9b
Compare
hakehuang
force-pushed
the
nxp_display
branch
2 times, most recently
from
7f9b647 to
81edf21
Compare
add display type for fixtures to avoid conflcts in NXP platform 1. add required regex for console harness. 2. add message after processing, ensure the flow is OK 3. reduce the test time in TEST mode Signed-off-by: Hake Huang <[email protected]>
hakehuang
force-pushed
the
nxp_display
branch
3 times, most recently
from
c644de0 to
a48dace
Compare
There was a problem hiding this comment.
Copyright should be updated- also, won't the display running with this sample on the RT595 use RGB565, not ARGB8888?
1. add lvgl status output after starts 2. add extra_args platfrom filterable 3. add some platfroms shield as extra_args Signed-off-by: Hake Huang <[email protected]>
hakehuang
force-pushed
the
nxp_display
branch
from
a48dace to
11fec27
Compare
7 participants
The original samples can not checked by twister only build check. with this PR, the board run testing can be checked by twister, although it can not check the display content, we can check the log and ensure the data flow is running.