Skip to content

Conversation

@ngphibang
Copy link
Contributor

  • Add camera colorbar pattern test: this is added via PRs Enhance camera fixture test #79337 and twister: runner: add extra_args supporting platform and soc and simulation #79263 to automatically check if a colorbar pattern generated by a camera pipeline is correct or not which is helpful to detect issue in a camera pipeline.
  • Add some fixed issues in video domain: the chicken-egg issue in init orders of the camera pipeline on NXP RT10xx platforms (a known issue exists more than a year due to technical obstacle, not a bug) and the floating point logging issue in video capture sample

@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Nov 13, 2024
@ngphibang ngphibang added this to the v4.0.0 milestone Nov 13, 2024
Comment on lines 736 to 738
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop these two as they are very specific and probably not worth mentioning in the global release notes imo

Copy link
Contributor Author

@ngphibang ngphibang Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, the last one is minor, I will drop it.

But the chicken-egg issue in init order is an issue that make camera not work on NXP 10xx platforms upstream for a long time. It seems worth mentionning to customers that camera is now working in upstream on those platforms ?

Also, this can happen to any (camera or else) pipeline where the receiver (e.g. CSI) needs to be initialized before the sensor to provide clock to the sensor (AFAIK at least the MCXN947 (ov7670/smartDMA) and Mediatek 8183 SoC have this same dependency which is not yet in Zephyr though) but if we change the receiver init priority, it will not compile because the receiver (e.g. CSI) node refers to the camera sensor node in the DT so it has to be initialized AFTER the sensor.

This is not a bug but rather a limitation in Zephyr DT which does not support circular dependency. This is "resolved" by replacing the phandle reference (remote-endpoint) by a string reference (remote-endpoint-label) in the new video-interfaces bindings, then get the remote device object with DT_STRING_TOKEN.

Sorry for the long comment but I would like to know if it's worth mentionning this in the upcomming Zephyr release techtalk too which is rather users-oriented (?), if you say no, I will drop it then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the first be better worded as Removed an init order circular dependency for the camera pipeline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkalowsk : yes, will do. Thanks.

Copy link
Contributor Author

@ngphibang ngphibang Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the wording and dropped the floating point logging issue as requested, waiting for @kartben 's advice if it's worth to add the "chicken-egg" issue in init order

@mmahadevan108
Copy link
Contributor

@ngphibang , release date is Nov 15. Can this be updated at the earliest.

This is added via PRs zephyrproject-rtos#79337 and zephyrproject-rtos#79263 to automatically check if a
colorbar pattern generated by a camera pipeline is correct or not.

Signed-off-by: Phi Bang Nguyen <[email protected]>
Add the chicken-egg issue on init order for the camera pipeline on NXP
RT10xx platforms

Signed-off-by: Phi Bang Nguyen <[email protected]>
Add link to the track the migration to the new video-interfaces
bindings.

Signed-off-by: Phi Bang Nguyen <[email protected]>
@ngphibang ngphibang requested a review from kartben November 14, 2024 17:40
@mmahadevan108
Copy link
Contributor

@kartben , kindly revisit this PR.

Copy link
Contributor

@dkalowsk dkalowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up this looks much better and consistent with the rest of the docs.

@mmahadevan108 mmahadevan108 merged commit c872b49 into zephyrproject-rtos:main Nov 14, 2024
16 checks passed
@ngphibang ngphibang deleted the fix_doc_release_4.0 branch November 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Notes To be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants