Skip to content

Conversation

@rveerama1
Copy link
Contributor

@rveerama1 rveerama1 commented Nov 17, 2017

This is a simple RPL based border router sample application. This can do routing between for example 802.15.4 and ethernet and act as a root node for RPL network. The router provides currently a very simple web UI for seeing the current nodes. Also new commands are added to net-shell to give better information about the RPL network. [Copied from https://github.com//pull/980].

Improve RPL neighbor and route handling functionality.
Improve net management event information mechanism.
Added more functionality in RPL Border Router sample to handle events and update web UI based on events, also draws network topology.
Added CoAP observer functionality to rpl_node sample.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edits

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include/net/websocket.h also defines a defgroup called websocket. Should this be named maybe websocket_console

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify what the "it" is that would be used, the net shell?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to "running an RPL border router"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "like" to "such as"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comma before "which"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"toward" seems an odd word here. Should it be "for"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to "in the configuration file"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either "is no board" or "are no boards"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... I thought you just said there aren't any boards that are supported?

Copy link
Contributor

@dbkinder dbkinder Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, no such document there on our wiki any more. Do I need to recover that material from my wiki archive for you to recreate what's needed here?

@codecov-io
Copy link

codecov-io commented Feb 8, 2018

Codecov Report

Merging #5035 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5035   +/-   ##
=======================================
  Coverage   55.25%   55.25%           
=======================================
  Files         468      468           
  Lines       51792    51792           
  Branches     9909     9909           
=======================================
  Hits        28618    28618           
  Misses      19261    19261           
  Partials     3913     3913

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06840af...290e06e. Read the comment docs.

@rveerama1
Copy link
Contributor Author

@dbkinder can please review doc updates?

@SebastianBoe SebastianBoe removed their request for review April 24, 2018 14:18
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tweak

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will render better like so:

* `FRDM-K64F with Freescale CR20A card 
<http://www.nxp.com/products/developer-resources/hardware-development-tools/freedom-development-boards/freedom-development-board-for-mcr20a-wireless-transceiver:FRDM-CR20A>`_.

@rveerama1 rveerama1 force-pushed the br branch 2 times, most recently from 33b442c to e002db3 Compare April 25, 2018 07:20
@rveerama1
Copy link
Contributor Author

rveerama1 commented Apr 25, 2018

@dbkinder updated according to your comments, please take a look.

@rveerama1
Copy link
Contributor Author

@dbkinder can you re-review this please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this a live link with:

Follow the instructions from :ref:`rpl-border-router-sample` to
run the Zephyr RPL border router.

@rveerama1
Copy link
Contributor Author

@dbkinder thanks, fixed comments, please take a look.

@rveerama1
Copy link
Contributor Author

@dbkinder can you please take a look ?

1 similar comment
@rveerama1
Copy link
Contributor Author

@dbkinder can you please take a look ?

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that does not belong here.

Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cleanup all the prj-*.conf files, create one that is global for platforms and then overlays for the specific boards and configurations. The configs have some duplicate configs, comments configs and probably obsolete ones as well, just keep those that are needed for the app to work. Take a look at samples/drivers/led_ws2812 for an example how to do that.

@rveerama1
Copy link
Contributor Author

@nashif updated according to your comments, can you please take a look ?

@rveerama1
Copy link
Contributor Author

@nashif ping

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide test entries for all the configs you are adding.

jukkar and others added 3 commits May 17, 2018 10:00
This is a very simple RPL border router sample application.
It provides HTTP(S) and net-shell interface for getting admin
information about neighbors and routes.

Signed-off-by: Jukka Rissanen <[email protected]>
Add CoAP client to RPL BR application. Which can be used to
control leds and get rpl related information from leaf nodes
though CoAP messages. Build toplogy matrics and send it to
Web UI.

Enhanced Web UI components (Interfaces, RPL, Neighbors, Routes
and Topology tabs). Added buttons to control leds on lead nodes.

Added JSON support to handle led on/off requests from UI.

Signed-off-by: Ravi kumar Veeramally <[email protected]>
If coap-client(e.g. RPL BR) wants to get notifications from
coap-server(RPL-node) about parent status, client has to register
observer for notifications.

RPL node application modified to toggle the LED. Do not maintain any
ON/OFF states. Also removed Sparrow (contiki border router) related
patch.

Signed-off-by: Ravi kumar Veeramally <[email protected]>
@rveerama1
Copy link
Contributor Author

@nashif I update rpl_node sample according to your comments.
From rpl_border_router I dropped combination of frdm_k64f + cc2520 conf files. More info about cc2520 + frdm combination is here #5274.

@nashif nashif merged commit 26ebb91 into zephyrproject-rtos:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants