-
Notifications
You must be signed in to change notification settings - Fork 8.2k
RPL border router sample application #5035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested edits
include/net/websocket_console.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include/net/websocket.h also defines a defgroup called websocket. Should this be named maybe websocket_console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify what the "it" is that would be used, the net shell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to "running an RPL border router"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change "like" to "such as"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comma before "which"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"toward" seems an odd word here. Should it be "for"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to "in the configuration file"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either "is no board" or "are no boards"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... I thought you just said there aren't any boards that are supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, no such document there on our wiki any more. Do I need to recover that material from my wiki archive for you to recreate what's needed here?
93ea6b4 to
7273b9a
Compare
Codecov Report
@@ Coverage Diff @@
## master #5035 +/- ##
=======================================
Coverage 55.25% 55.25%
=======================================
Files 468 468
Lines 51792 51792
Branches 9909 9909
=======================================
Hits 28618 28618
Misses 19261 19261
Partials 3913 3913Continue to review full report at Codecov.
|
254c83c to
be3b9b3
Compare
42ef815 to
68eef1e
Compare
|
@dbkinder can please review doc updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tweak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will render better like so:
* `FRDM-K64F with Freescale CR20A card
<http://www.nxp.com/products/developer-resources/hardware-development-tools/freedom-development-boards/freedom-development-board-for-mcr20a-wireless-transceiver:FRDM-CR20A>`_.
33b442c to
e002db3
Compare
|
@dbkinder updated according to your comments, please take a look. |
|
@dbkinder can you re-review this please? |
samples/net/rpl_node/README.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make this a live link with:
Follow the instructions from :ref:`rpl-border-router-sample` to
run the Zephyr RPL border router.
|
@dbkinder thanks, fixed comments, please take a look. |
|
@dbkinder can you please take a look ? |
1 similar comment
|
@dbkinder can you please take a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that does not belong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cleanup all the prj-*.conf files, create one that is global for platforms and then overlays for the specific boards and configurations. The configs have some duplicate configs, comments configs and probably obsolete ones as well, just keep those that are needed for the app to work. Take a look at samples/drivers/led_ws2812 for an example how to do that.
|
@nashif updated according to your comments, can you please take a look ? |
|
@nashif ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide test entries for all the configs you are adding.
This is a very simple RPL border router sample application. It provides HTTP(S) and net-shell interface for getting admin information about neighbors and routes. Signed-off-by: Jukka Rissanen <[email protected]>
Add CoAP client to RPL BR application. Which can be used to control leds and get rpl related information from leaf nodes though CoAP messages. Build toplogy matrics and send it to Web UI. Enhanced Web UI components (Interfaces, RPL, Neighbors, Routes and Topology tabs). Added buttons to control leds on lead nodes. Added JSON support to handle led on/off requests from UI. Signed-off-by: Ravi kumar Veeramally <[email protected]>
If coap-client(e.g. RPL BR) wants to get notifications from coap-server(RPL-node) about parent status, client has to register observer for notifications. RPL node application modified to toggle the LED. Do not maintain any ON/OFF states. Also removed Sparrow (contiki border router) related patch. Signed-off-by: Ravi kumar Veeramally <[email protected]>
This is a simple RPL based border router sample application. This can do routing between for example 802.15.4 and ethernet and act as a root node for RPL network. The router provides currently a very simple web UI for seeing the current nodes. Also new commands are added to net-shell to give better information about the RPL network. [Copied from https://github.com//pull/980].
Improve RPL neighbor and route handling functionality.
Improve net management event information mechanism.
Added more functionality in RPL Border Router sample to handle events and update web UI based on events, also draws network topology.
Added CoAP observer functionality to rpl_node sample.